From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: wsa@the-dreams.de
Cc: Kalyan Kinthada <kalyan.kinthada@alliedtelesis.co.nz>,
jason@lakedaemon.net, andrew@lunn.ch,
sebastian.hesselbarth@gmail.com, robh+dt@kernel.org,
mark.rutland@arm.com, linux@armlinux.org.uk,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
Chris Packham <chris.packham@alliedtelesis.co.nz>
Subject: Re: [PATCH v2 2/2] dt-bindings: i2c: Update documentation for "mv78230-a0-i2c"
Date: Mon, 02 Oct 2017 16:23:43 +0200 [thread overview]
Message-ID: <87k20dmxw0.fsf@free-electrons.com> (raw)
In-Reply-To: <20170928213605.22874-3-kalyan.kinthada@alliedtelesis.co.nz> (Kalyan Kinthada's message of "Fri, 29 Sep 2017 10:36:05 +1300")
Hi Wolfram,
On ven., sept. 29 2017, Kalyan Kinthada <kalyan.kinthada@alliedtelesis.co.nz> wrote:
> This commit modifies the documentation for
> "marvell,mv78230-a0-i2c" compatible string.
>
> The "marvell,mv78230-a0-i2c" compatible string enables the workaround
> for an i2c repeated start timing violation, but unlike
> "marvell,mv78230-i2c" it disables the i2c offload support. This is
> applicable to a number of SoCs such as early revisions of the Armada XP
> and the Armada 38x.
>
> Signed-off-by: Kalyan Kinthada <kalyan.kinthada@alliedtelesis.co.nz>
I applied the dt fix on my mvebu/fixes branch. Do you want to apply this
one on your branch, or do you prefer I take it. In this case an acked-by
would be nice.
Thanks,
Gregory
> ---
> Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt b/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt
> index 5c30026921ae..c6cbab17ed0a 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt
> @@ -10,10 +10,12 @@ Required properties :
> - "marvell,mv64xxx-i2c"
> - "marvell,mv78230-i2c"
> - "marvell,mv78230-a0-i2c"
> - * Note: Only use "marvell,mv78230-a0-i2c" for a
> - very rare, initial version of the SoC which
> - had broken offload support. Linux
> - auto-detects this and sets it appropriately.
> + * Note: Use "marvell,mv78230-a0-i2c" for
> + controller which do not support offload
> + but still have the i2c repeated start
> + timing violation issue, such as the
> + ones found in the Armada XP A0 and the
> + Armada 38x SoCs.
> - interrupts : The interrupt number
>
> Optional properties :
> --
> 2.14.1
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2017-10-02 14:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 21:36 [PATCH v2 0/2] Fix I2C repeated start timing violation on Armada-38x Kalyan Kinthada
2017-09-28 21:36 ` [PATCH v2 1/2] ARM: dts: Fix I2C repeated start issue " Kalyan Kinthada
2017-10-02 14:21 ` Gregory CLEMENT
2017-09-28 21:36 ` [PATCH v2 2/2] dt-bindings: i2c: Update documentation for "mv78230-a0-i2c" Kalyan Kinthada
2017-10-02 14:23 ` Gregory CLEMENT [this message]
2017-10-05 11:08 ` Wolfram Sang
2017-10-05 23:29 ` Rob Herring
2017-11-05 12:54 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k20dmxw0.fsf@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=kalyan.kinthada@alliedtelesis.co.nz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome