From: Michael Ellerman <mpe@ellerman.id.au>
To: Greg Kurz <groug@kaod.org>, linuxppc-dev@lists.ozlabs.org
Cc: linux-kernel@vger.kernel.org,
Frederic Barrat <fbarrat@linux.vnet.ibm.com>,
Ian Munsie <imunsie@au1.ibm.com>
Subject: Re: [PATCH] cxl: drop unused header asm/pnv-pci.h
Date: Tue, 24 Jan 2017 20:57:06 +1100 [thread overview]
Message-ID: <87k29kaih9.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <148482301037.30441.14177888563610790803.stgit@bahia>
Greg Kurz <groug@kaod.org> writes:
> The kernel API does not use anything from this header file.
That's actually hard to prove in general, because pnv-pci.h includes
linux/pci.h, linux/pci_hotplug.h, linux/irq.h, misc/cxl-base.h and
asm/opal-api.h. At least four of which aren't included directly by
api.c.
But I'll take you word for it :)
cheers
> diff --git a/drivers/misc/cxl/api.c b/drivers/misc/cxl/api.c
> index 1b35e33d2434..bcc030eacab7 100644
> --- a/drivers/misc/cxl/api.c
> +++ b/drivers/misc/cxl/api.c
> @@ -11,7 +11,6 @@
> #include <linux/slab.h>
> #include <linux/file.h>
> #include <misc/cxl.h>
> -#include <asm/pnv-pci.h>
> #include <linux/msi.h>
> #include <linux/module.h>
> #include <linux/mount.h>
next prev parent reply other threads:[~2017-01-24 9:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 10:50 Greg Kurz
2017-01-19 12:24 ` Andrew Donnellan
2017-01-21 18:39 ` Frederic Barrat
2017-01-24 9:57 ` Michael Ellerman [this message]
2017-01-24 11:48 ` Greg Kurz
2017-01-24 23:22 ` Andrew Donnellan
2017-01-27 0:40 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k29kaih9.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=fbarrat@linux.vnet.ibm.com \
--cc=groug@kaod.org \
--cc=imunsie@au1.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®