mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Dave Hansen <dave@sr71.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Kees Cook <keescook@chromium.org>,
	tytso@mit.edu, Oleg Nesterov <oleg@redhat.com>,
	linux-kernel@vger.kernel.org, dave.hansen@linux.intel.com
Subject: Re: [RFCv2][PATCH 1/2] fs proc: make pagemap a privileged interface
Date: Tue, 17 Mar 2015 08:04:40 -0500	[thread overview]
Message-ID: <87k2yflqqf.fsf@x220.int.ebiederm.org> (raw)
In-Reply-To: <20150316230221.DA32D9BE@viggo.jf.intel.com> (Dave Hansen's message of "Mon, 16 Mar 2015 16:02:21 -0700")

Dave Hansen <dave@sr71.net> writes:

> From: Dave Hansen <dave.hansen@linux.intel.com>
>
> Changes from v1:
>  * Do not allow a child pid namespace to unset paranoid
>    when its parent had it set.
>  * Update description text to clarify the options we
>    have to solve this problem.

Again.

Nacked-by: "Eric W. Biederman" <ebiederm@xmission.com>

The option name "paranoid" is entirely too general.  Who knows what
it referrs to.

A mount option is not an appropriate place to control one small bit of
policy like this.  Proc mount options are a real pain in the butt to
deal with and to maintain. 

Further a per pid namespace decision does not actually work, for having
restricted policy only for a small set of processes because it is only
with very careful container setup that you would expose this policy.

If you really need a subset of processes with a restricted policy make
it a prctl, and bloat struct task.  Then disallow a process with the
prctl set from reading the file.

Eric

       reply	other threads:[~2015-03-17 13:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20150316230221.DA32D9BE@viggo.jf.intel.com>
2015-03-17 13:04 ` Eric W. Biederman [this message]
2015-03-17 14:51   ` Dave Hansen
2015-03-17 18:24     ` Eric W. Biederman
2015-03-20 16:56       ` Tony Luck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k2yflqqf.fsf@x220.int.ebiederm.org \
    --to=ebiederm@xmission.com \
    --cc=akpm@linux-foundation.org \
    --cc=dave.hansen@linux.intel.com \
    --cc=dave@sr71.net \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome