mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Gergo Koteles <soyer@irl.hu>
Cc: Takashi Iwai <tiwai@suse.de>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	Will Bush <will@willbush.dev>
Subject: Re: [PATCH] ALSA: usb-audio: Avoid applying boot quirk for Behringer UMC204HD
Date: Sat, 24 Oct 2026 09:59:44 +0200	[thread overview]
Message-ID: <87ld7n8r67.wl-tiwai@suse.de> (raw)
In-Reply-To: <8075e4d5ed4b5523a088840c5574d4c0e49307ff.camel@irl.hu>

On Fri, 23 Oct 2026 22:04:02 +0200,
Gergo Koteles wrote:
> 
> Hi Takashi,
> 
> On Mon, 2026-10-19 at 12:23 +0200, Takashi Iwai wrote:
> > There have been reports about a regression with the recent boot quirk
> > for Behringer devices; it broke UMC204HD models(1397:0508 and
> > 1397:0509).  The quirk was to just run usb_get_descriptor(), so I
> > expected it rather harmful, but in this case, it doesn't look so,
> > resulting in an error like 'failed to read device descriptor: -110'
> > that leads to a fatal probe error.
> > 
> > As a quick workaround, skip the quirk for those UMC204HD models.
> > 
> > Fixes: b5c4823cf3e4 ("ALSA: usb-audio: Apply boot quirk for Behringer models generically")
> > Reported-by: Will Bush <will@willbush.dev>
> > Closes: https://lore.kernel.org/45162613-2802-401c-84c9-742f9c8c68e6@app.fastmail.com
> > Closes: https://bugzilla.suse.com/show_bug.cgi?id=1285896
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> > ---
> >  sound/usb/quirks.c | 9 ++++++++-
> >  1 file changed, 8 insertions(+), 1 deletion(-)
> > 
> > diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
> > index 4fadb1fdcdea..4ac4aef47dd7 100644
> > --- a/sound/usb/quirks.c
> > +++ b/sound/usb/quirks.c
> > @@ -1790,8 +1790,15 @@ int snd_usb_apply_boot_quirk_once(struct usb_device *dev,
> >  	}
> >  
> >  	/* Behringer devices may need explicit device descriptor read at boot */
> > -	if (USB_ID_VENDOR(id) == 0x1397)
> > +	if (USB_ID_VENDOR(id) == 0x1397) {
> > +		/* the quirk seems breaking on some Behringer devices */
> > +		switch (id) {
> > +		case USB_ID(0x1397, 0x0508): /* UMC204HD */
> > +		case USB_ID(0x1397, 0x0509): /* UMC204HD */
> 
> 0x0509 is the UMC404HD
> 
> https://linux-hardware.org/?id=usb:1397-0509

You're right.  I'll correct it.


thanks,

Takashi

  reply	other threads:[~2026-10-24  7:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-19 10:23 Takashi Iwai
2026-10-23 20:04 ` Gergo Koteles
2026-10-24  7:59   ` Takashi Iwai [this message]
2026-10-24 10:26 ` Will Bush

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ld7n8r67.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=soyer@irl.hu \
    --cc=will@willbush.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®