mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] ALSA: usb-audio: Avoid applying boot quirk for Behringer UMC204HD
@ 2026-10-19 10:23 Takashi Iwai
  2026-10-23 20:04 ` Gergo Koteles
  2026-10-24 10:26 ` Will Bush
  0 siblings, 2 replies; 4+ messages in thread
From: Takashi Iwai @ 2026-10-19 10:23 UTC (permalink / raw)
  To: linux-sound; +Cc: linux-kernel, Will Bush

There have been reports about a regression with the recent boot quirk
for Behringer devices; it broke UMC204HD models(1397:0508 and
1397:0509).  The quirk was to just run usb_get_descriptor(), so I
expected it rather harmful, but in this case, it doesn't look so,
resulting in an error like 'failed to read device descriptor: -110'
that leads to a fatal probe error.

As a quick workaround, skip the quirk for those UMC204HD models.

Fixes: b5c4823cf3e4 ("ALSA: usb-audio: Apply boot quirk for Behringer models generically")
Reported-by: Will Bush <will@willbush.dev>
Closes: https://lore.kernel.org/45162613-2802-401c-84c9-742f9c8c68e6@app.fastmail.com
Closes: https://bugzilla.suse.com/show_bug.cgi?id=1285896
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/usb/quirks.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
index 4fadb1fdcdea..4ac4aef47dd7 100644
--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -1790,8 +1790,15 @@ int snd_usb_apply_boot_quirk_once(struct usb_device *dev,
 	}
 
 	/* Behringer devices may need explicit device descriptor read at boot */
-	if (USB_ID_VENDOR(id) == 0x1397)
+	if (USB_ID_VENDOR(id) == 0x1397) {
+		/* the quirk seems breaking on some Behringer devices */
+		switch (id) {
+		case USB_ID(0x1397, 0x0508): /* UMC204HD */
+		case USB_ID(0x1397, 0x0509): /* UMC204HD */
+			return 0;
+		}
 		return snd_usb_cm1a_boot_quirk(dev);
+	}
 
 	return 0;
 }
-- 
2.55.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ALSA: usb-audio: Avoid applying boot quirk for Behringer UMC204HD
  2026-10-19 10:23 [PATCH] ALSA: usb-audio: Avoid applying boot quirk for Behringer UMC204HD Takashi Iwai
@ 2026-10-23 20:04 ` Gergo Koteles
  2026-10-24  7:59   ` Takashi Iwai
  2026-10-24 10:26 ` Will Bush
  1 sibling, 1 reply; 4+ messages in thread
From: Gergo Koteles @ 2026-10-23 20:04 UTC (permalink / raw)
  To: Takashi Iwai, linux-sound; +Cc: linux-kernel, Will Bush

Hi Takashi,

On Mon, 2026-10-19 at 12:23 +0200, Takashi Iwai wrote:
> There have been reports about a regression with the recent boot quirk
> for Behringer devices; it broke UMC204HD models(1397:0508 and
> 1397:0509).  The quirk was to just run usb_get_descriptor(), so I
> expected it rather harmful, but in this case, it doesn't look so,
> resulting in an error like 'failed to read device descriptor: -110'
> that leads to a fatal probe error.
> 
> As a quick workaround, skip the quirk for those UMC204HD models.
> 
> Fixes: b5c4823cf3e4 ("ALSA: usb-audio: Apply boot quirk for Behringer models generically")
> Reported-by: Will Bush <will@willbush.dev>
> Closes: https://lore.kernel.org/45162613-2802-401c-84c9-742f9c8c68e6@app.fastmail.com
> Closes: https://bugzilla.suse.com/show_bug.cgi?id=1285896
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
>  sound/usb/quirks.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
> index 4fadb1fdcdea..4ac4aef47dd7 100644
> --- a/sound/usb/quirks.c
> +++ b/sound/usb/quirks.c
> @@ -1790,8 +1790,15 @@ int snd_usb_apply_boot_quirk_once(struct usb_device *dev,
>  	}
>  
>  	/* Behringer devices may need explicit device descriptor read at boot */
> -	if (USB_ID_VENDOR(id) == 0x1397)
> +	if (USB_ID_VENDOR(id) == 0x1397) {
> +		/* the quirk seems breaking on some Behringer devices */
> +		switch (id) {
> +		case USB_ID(0x1397, 0x0508): /* UMC204HD */
> +		case USB_ID(0x1397, 0x0509): /* UMC204HD */

0x0509 is the UMC404HD

https://linux-hardware.org/?id=usb:1397-0509

Best regards,
Gergo

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ALSA: usb-audio: Avoid applying boot quirk for Behringer UMC204HD
  2026-10-23 20:04 ` Gergo Koteles
@ 2026-10-24  7:59   ` Takashi Iwai
  0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2026-10-24  7:59 UTC (permalink / raw)
  To: Gergo Koteles; +Cc: Takashi Iwai, linux-sound, linux-kernel, Will Bush

On Fri, 23 Oct 2026 22:04:02 +0200,
Gergo Koteles wrote:
> 
> Hi Takashi,
> 
> On Mon, 2026-10-19 at 12:23 +0200, Takashi Iwai wrote:
> > There have been reports about a regression with the recent boot quirk
> > for Behringer devices; it broke UMC204HD models(1397:0508 and
> > 1397:0509).  The quirk was to just run usb_get_descriptor(), so I
> > expected it rather harmful, but in this case, it doesn't look so,
> > resulting in an error like 'failed to read device descriptor: -110'
> > that leads to a fatal probe error.
> > 
> > As a quick workaround, skip the quirk for those UMC204HD models.
> > 
> > Fixes: b5c4823cf3e4 ("ALSA: usb-audio: Apply boot quirk for Behringer models generically")
> > Reported-by: Will Bush <will@willbush.dev>
> > Closes: https://lore.kernel.org/45162613-2802-401c-84c9-742f9c8c68e6@app.fastmail.com
> > Closes: https://bugzilla.suse.com/show_bug.cgi?id=1285896
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> > ---
> >  sound/usb/quirks.c | 9 ++++++++-
> >  1 file changed, 8 insertions(+), 1 deletion(-)
> > 
> > diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
> > index 4fadb1fdcdea..4ac4aef47dd7 100644
> > --- a/sound/usb/quirks.c
> > +++ b/sound/usb/quirks.c
> > @@ -1790,8 +1790,15 @@ int snd_usb_apply_boot_quirk_once(struct usb_device *dev,
> >  	}
> >  
> >  	/* Behringer devices may need explicit device descriptor read at boot */
> > -	if (USB_ID_VENDOR(id) == 0x1397)
> > +	if (USB_ID_VENDOR(id) == 0x1397) {
> > +		/* the quirk seems breaking on some Behringer devices */
> > +		switch (id) {
> > +		case USB_ID(0x1397, 0x0508): /* UMC204HD */
> > +		case USB_ID(0x1397, 0x0509): /* UMC204HD */
> 
> 0x0509 is the UMC404HD
> 
> https://linux-hardware.org/?id=usb:1397-0509

You're right.  I'll correct it.


thanks,

Takashi

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ALSA: usb-audio: Avoid applying boot quirk for Behringer UMC204HD
  2026-10-19 10:23 [PATCH] ALSA: usb-audio: Avoid applying boot quirk for Behringer UMC204HD Takashi Iwai
  2026-10-23 20:04 ` Gergo Koteles
@ 2026-10-24 10:26 ` Will Bush
  1 sibling, 0 replies; 4+ messages in thread
From: Will Bush @ 2026-10-24 10:26 UTC (permalink / raw)
  To: Takashi Iwai, linux-sound; +Cc: linux-kernel

On Mon, Oct 19, 2026, at 5:23 AM, Takashi Iwai wrote:
> As a quick workaround, skip the quirk for those UMC204HD models.

I tested your patch on 7.2.10 with my UMC204HD (1397:0508) and it works. Thanks!

Tested-by: Will Bush <will@willbush.dev>

Best,
Will

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-10-24 10:26 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-19 10:23 [PATCH] ALSA: usb-audio: Avoid applying boot quirk for Behringer UMC204HD Takashi Iwai
2026-10-23 20:04 ` Gergo Koteles
2026-10-24  7:59   ` Takashi Iwai
2026-10-24 10:26 ` Will Bush

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®