mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] ALSA: hda/realtek: Add support for ASUS NUC14LNK system which uses Realtek ALC245 codec and CS35L41 amplifier over SPI. Without this quirk, the amp probe fails with -EINVAL and no sound is initialized.
@ 2025-07-04  2:39 Seiji Nishikawa
  2025-07-04  3:02 ` [PATCH v2] ALSA: hda/realtek: Add quirk for ASUS NUC14LNK with CS35L41 Seiji Nishikawa
  0 siblings, 1 reply; 3+ messages in thread
From: Seiji Nishikawa @ 2025-07-04  2:39 UTC (permalink / raw)
  To: perex, tiwai; +Cc: linux-sound, linux-kernel, snishika

Signed-off-by: Seiji Nishikawa <snishika@redhat.com>
---
 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 5d6d01ecfee2..7ce54db56354 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -11084,6 +11084,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1043, 0x8398, "ASUS P1005", ALC269_FIXUP_STEREO_DMIC),
 	SND_PCI_QUIRK(0x1043, 0x83ce, "ASUS P1005", ALC269_FIXUP_STEREO_DMIC),
 	SND_PCI_QUIRK(0x1043, 0x8516, "ASUS X101CH", ALC269_FIXUP_ASUS_X101),
+	SND_PCI_QUIRK(0x1043, 0x88f4, "ASUS NUC14LNK", ALC245_FIXUP_CS35L41_SPI_2),
 	SND_PCI_QUIRK(0x104d, 0x9073, "Sony VAIO", ALC275_FIXUP_SONY_VAIO_GPIO2),
 	SND_PCI_QUIRK(0x104d, 0x907b, "Sony VAIO", ALC275_FIXUP_SONY_HWEQ),
 	SND_PCI_QUIRK(0x104d, 0x9084, "Sony VAIO", ALC275_FIXUP_SONY_HWEQ),
-- 
2.50.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v2] ALSA: hda/realtek: Add quirk for ASUS NUC14LNK with CS35L41
  2025-07-04  2:39 [PATCH] ALSA: hda/realtek: Add support for ASUS NUC14LNK system which uses Realtek ALC245 codec and CS35L41 amplifier over SPI. Without this quirk, the amp probe fails with -EINVAL and no sound is initialized Seiji Nishikawa
@ 2025-07-04  3:02 ` Seiji Nishikawa
  2025-07-04 12:08   ` Takashi Iwai
  0 siblings, 1 reply; 3+ messages in thread
From: Seiji Nishikawa @ 2025-07-04  3:02 UTC (permalink / raw)
  To: perex, tiwai; +Cc: linux-sound, linux-kernel, snishika

Add support for ASUS NUC14LNK system which uses Realtek ALC245 codec
and CS35L41 amplifier over SPI. Without this quirk, the amp probe fails
with -EINVAL and no sound is initialized.

Signed-off-by: Seiji Nishikawa <snishika@redhat.com>

v2: fixed unintentional formatting issue in subject line and commit message

---
 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 5d6d01ecfee2..7ce54db56354 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -11084,6 +11084,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1043, 0x8398, "ASUS P1005", ALC269_FIXUP_STEREO_DMIC),
 	SND_PCI_QUIRK(0x1043, 0x83ce, "ASUS P1005", ALC269_FIXUP_STEREO_DMIC),
 	SND_PCI_QUIRK(0x1043, 0x8516, "ASUS X101CH", ALC269_FIXUP_ASUS_X101),
+	SND_PCI_QUIRK(0x1043, 0x88f4, "ASUS NUC14LNK", ALC245_FIXUP_CS35L41_SPI_2),
 	SND_PCI_QUIRK(0x104d, 0x9073, "Sony VAIO", ALC275_FIXUP_SONY_VAIO_GPIO2),
 	SND_PCI_QUIRK(0x104d, 0x907b, "Sony VAIO", ALC275_FIXUP_SONY_HWEQ),
 	SND_PCI_QUIRK(0x104d, 0x9084, "Sony VAIO", ALC275_FIXUP_SONY_HWEQ),
-- 
2.50.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] ALSA: hda/realtek: Add quirk for ASUS NUC14LNK with CS35L41
  2025-07-04  3:02 ` [PATCH v2] ALSA: hda/realtek: Add quirk for ASUS NUC14LNK with CS35L41 Seiji Nishikawa
@ 2025-07-04 12:08   ` Takashi Iwai
  0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2025-07-04 12:08 UTC (permalink / raw)
  To: Seiji Nishikawa; +Cc: perex, tiwai, linux-sound, linux-kernel

On Fri, 04 Jul 2025 05:02:32 +0200,
Seiji Nishikawa wrote:
> 
> Add support for ASUS NUC14LNK system which uses Realtek ALC245 codec
> and CS35L41 amplifier over SPI. Without this quirk, the amp probe fails
> with -EINVAL and no sound is initialized.
> 
> Signed-off-by: Seiji Nishikawa <snishika@redhat.com>
> 
> v2: fixed unintentional formatting issue in subject line and commit message

The proper fix has been already queued in for-next branch (i.e. for
6.17 kernel), commit commit 84fc8896f0d9d1c075e0e08a416faedbd73907fa


thanks,

Takashi

> 
> ---
>  sound/pci/hda/patch_realtek.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 5d6d01ecfee2..7ce54db56354 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -11084,6 +11084,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x1043, 0x8398, "ASUS P1005", ALC269_FIXUP_STEREO_DMIC),
>  	SND_PCI_QUIRK(0x1043, 0x83ce, "ASUS P1005", ALC269_FIXUP_STEREO_DMIC),
>  	SND_PCI_QUIRK(0x1043, 0x8516, "ASUS X101CH", ALC269_FIXUP_ASUS_X101),
> +	SND_PCI_QUIRK(0x1043, 0x88f4, "ASUS NUC14LNK", ALC245_FIXUP_CS35L41_SPI_2),
>  	SND_PCI_QUIRK(0x104d, 0x9073, "Sony VAIO", ALC275_FIXUP_SONY_VAIO_GPIO2),
>  	SND_PCI_QUIRK(0x104d, 0x907b, "Sony VAIO", ALC275_FIXUP_SONY_HWEQ),
>  	SND_PCI_QUIRK(0x104d, 0x9084, "Sony VAIO", ALC275_FIXUP_SONY_HWEQ),
> -- 
> 2.50.0
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-07-04 12:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-07-04  2:39 [PATCH] ALSA: hda/realtek: Add support for ASUS NUC14LNK system which uses Realtek ALC245 codec and CS35L41 amplifier over SPI. Without this quirk, the amp probe fails with -EINVAL and no sound is initialized Seiji Nishikawa
2025-07-04  3:02 ` [PATCH v2] ALSA: hda/realtek: Add quirk for ASUS NUC14LNK with CS35L41 Seiji Nishikawa
2025-07-04 12:08   ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®