mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Alexandre Bounine <alexandre.bounine@idt.com>,
	Matt Porter <mporter@kernel.crashing.org>,
	Andre van Herk <andre.van.herk@prodrive-technologies.com>,
	Barry Wood <barry.wood@idt.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 11/13] rapidio: modify for rev.3 specification changes
Date: Thu, 28 Jul 2016 23:52:47 +1000	[thread overview]
Message-ID: <87lh0l7tu8.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20160727123713.8d61bed160fbfa3631b0066e@linux-foundation.org>

Andrew Morton <akpm@linux-foundation.org> writes:

> On Wed, 27 Jul 2016 14:53:25 +1000 Michael Ellerman <mpe@ellerman.id.au> wrote:
>> arch/powerpc/sysdev/fsl_rio.c:702:11: error: 'struct rio_mport' has no member named 'phy_type'
>> arch/powerpc/sysdev/fsl_rio.c:702:25: error: 'RIO_PHY_SERIAL' undeclared (first use in this function)
>
> I'll go out on a limb and assume it's this:
>
> --- a/arch/powerpc/sysdev/fsl_rio.c~powerpc-fsl_rio-apply-changes-for-rio-spec-rev-3-fix
> +++ a/arch/powerpc/sysdev/fsl_rio.c
> @@ -698,11 +698,6 @@ int fsl_rio_setup(struct platform_device
>  			RIO_INB_ATMU_REGS_PORT2_OFFSET));
>  
>  
> -		/* Set to receive any dist ID for serial RapidIO controller. */
> -		if (port->phy_type == RIO_PHY_SERIAL)
> -			out_be32((priv->regs_win
> -				+ RIO_ISR_AACR + i*0x80), RIO_ISR_AACR_AA);
> -

Yep, thanks.

Hopefully someone somewhere is testing this on powerpc, I don't have one
of those FSL boxes. But at least it will build now.

cheers

  reply	other threads:[~2016-07-28 13:52 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-21 18:18 [PATCH 00/13] RapidIO subsystem updates Alexandre Bounine
2016-07-21 18:18 ` [PATCH 01/13] rapidio: Remove unnecessary 0x prefixes before %pa extension uses Alexandre Bounine
2016-07-21 18:18 ` [PATCH 02/13] rapidio/documentation: fix mangled paragraph in mport_cdev Alexandre Bounine
2016-07-21 18:18 ` [PATCH 03/13] rapidio: fix return value description for dma_prep functions Alexandre Bounine
2016-07-21 18:18 ` [PATCH 04/13] rapidio/tsi721_dma: add channel mask and queue size parameters Alexandre Bounine
2016-07-21 18:18 ` [PATCH 05/13] rapidio/tsi721: add PCIe MRRS override parameter Alexandre Bounine
2016-07-21 18:18 ` [PATCH 06/13] rapidio/tsi721: add messaging mbox selector parameter Alexandre Bounine
2016-07-21 18:18 ` [PATCH 07/13] rapidio/tsi721_dma: advance queue processing from transfer submit call Alexandre Bounine
2016-07-21 18:18 ` [PATCH 08/13] rapidio: fix error handling in mbox request/release functions Alexandre Bounine
2016-07-21 18:18 ` [PATCH 09/13] rapidio/idt_gen2: fix locking warning Alexandre Bounine
2016-07-21 18:18 ` [PATCH 10/13] rapidio: change inbound window size type to u64 Alexandre Bounine
2016-07-21 18:18 ` [PATCH 11/13] rapidio: modify for rev.3 specification changes Alexandre Bounine
2016-07-27  4:53   ` Michael Ellerman
2016-07-27 10:20     ` Wood, Barry
2016-07-27 19:37     ` Andrew Morton
2016-07-28 13:52       ` Michael Ellerman [this message]
2016-07-21 18:18 ` [PATCH 12/13] powerpc/fsl_rio: apply changes for RIO spec rev 3 Alexandre Bounine
2016-07-21 18:18 ` [PATCH 13/13] rapidio/switches: add driver for IDT gen3 switches Alexandre Bounine
2016-07-21 18:36   ` Andrew Morton
2016-07-21 18:48     ` Bounine, Alexandre
2016-07-21 19:01       ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lh0l7tu8.fsf@concordia.ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=akpm@linux-foundation.org \
    --cc=alexandre.bounine@idt.com \
    --cc=andre.van.herk@prodrive-technologies.com \
    --cc=barry.wood@idt.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mporter@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®