* [PATCH v2 0/2] usb: dwc3: add disable receiver detection in P3 quirk
@ 2016-03-14 9:10 Rajesh Bhagat
2016-03-14 9:10 ` [PATCH v2 1/2] " Rajesh Bhagat
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Rajesh Bhagat @ 2016-03-14 9:10 UTC (permalink / raw)
To: balbi
Cc: gregkh, linux-usb, linux-kernel, linux-omap, sriram.dash, Rajesh Bhagat
Adds disable receiver detection in P3 quirk in DWC3 driver.
Rajesh Bhagat (2):
usb: dwc3: add disable receiver detection in P3 quirk
Documentation: dt: dwc3: Add snps,dis_rxdet_inp3_quirk property
Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++
drivers/usb/dwc3/core.c | 6 ++++++
drivers/usb/dwc3/core.h | 2 ++
drivers/usb/dwc3/platform_data.h | 1 +
4 files changed, 11 insertions(+)
--
2.6.2.198.g614a2ac
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 1/2] usb: dwc3: add disable receiver detection in P3 quirk
2016-03-14 9:10 [PATCH v2 0/2] usb: dwc3: add disable receiver detection in P3 quirk Rajesh Bhagat
@ 2016-03-14 9:10 ` Rajesh Bhagat
2016-03-14 9:10 ` [PATCH v2 2/2] Documentation: dt: dwc3: Add snps,dis_rxdet_inp3_quirk property Rajesh Bhagat
[not found] ` <DB5PR0401MB2024DEBF67F3990558A1D6BBF56B0@DB5PR0401MB2024.eurprd04.prod.outlook.com>
2 siblings, 0 replies; 6+ messages in thread
From: Rajesh Bhagat @ 2016-03-14 9:10 UTC (permalink / raw)
To: balbi
Cc: gregkh, linux-usb, linux-kernel, linux-omap, sriram.dash, Rajesh Bhagat
Some freescale QorIQ platforms require to disable receiver detection
in P3 for correct detection of USB devices. If GUSB3PIPECTL(DISRXDETINP3)
is set, Core will change PHY power state to P2 and then perform receiver
detection. After receiver detection, Core will change PHY power state to
P3. Same quirk would be added in dts file in future patches.
Signed-off-by: Sriram Dash <sriram.dash@nxp.com>
Signed-off-by: Rajesh Bhagat <rajesh.bhagat@nxp.com>
---
Changes for v2 :
- added the property code in alphabetical order.
drivers/usb/dwc3/core.c | 6 ++++++
drivers/usb/dwc3/core.h | 2 ++
drivers/usb/dwc3/platform_data.h | 1 +
3 files changed, 9 insertions(+)
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index de5e01f..c840df0 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -446,6 +446,9 @@ static int dwc3_phy_setup(struct dwc3 *dwc)
if (dwc->u2ss_inp3_quirk)
reg |= DWC3_GUSB3PIPECTL_U2SSINP3OK;
+ if (dwc->dis_rxdet_inp3_quirk)
+ reg |= DWC3_GUSB3PIPECTL_DISRXDETINP3;
+
if (dwc->req_p1p2p3_quirk)
reg |= DWC3_GUSB3PIPECTL_REQP1P2P3;
@@ -919,6 +922,8 @@ static int dwc3_probe(struct platform_device *pdev)
"snps,dis_u2_susphy_quirk");
dwc->dis_enblslpm_quirk = device_property_read_bool(dev,
"snps,dis_enblslpm_quirk");
+ dwc->dis_rxdet_inp3_quirk = device_property_read_bool(dev,
+ "snps,dis_rxdet_inp3_quirk");
dwc->tx_de_emphasis_quirk = device_property_read_bool(dev,
"snps,tx_de_emphasis_quirk");
@@ -953,6 +958,7 @@ static int dwc3_probe(struct platform_device *pdev)
dwc->dis_u3_susphy_quirk = pdata->dis_u3_susphy_quirk;
dwc->dis_u2_susphy_quirk = pdata->dis_u2_susphy_quirk;
dwc->dis_enblslpm_quirk = pdata->dis_enblslpm_quirk;
+ dwc->dis_rxdet_inp3_quirk = pdata->dis_rxdet_inp3_quirk;
dwc->tx_de_emphasis_quirk = pdata->tx_de_emphasis_quirk;
if (pdata->tx_de_emphasis)
diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index e4f8b90..494119c 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -193,6 +193,7 @@
/* Global USB3 PIPE Control Register */
#define DWC3_GUSB3PIPECTL_PHYSOFTRST (1 << 31)
#define DWC3_GUSB3PIPECTL_U2SSINP3OK (1 << 29)
+#define DWC3_GUSB3PIPECTL_DISRXDETINP3 (1 << 28)
#define DWC3_GUSB3PIPECTL_REQP1P2P3 (1 << 24)
#define DWC3_GUSB3PIPECTL_DEP1P2P3(n) ((n) << 19)
#define DWC3_GUSB3PIPECTL_DEP1P2P3_MASK DWC3_GUSB3PIPECTL_DEP1P2P3(7)
@@ -870,6 +871,7 @@ struct dwc3 {
unsigned dis_u3_susphy_quirk:1;
unsigned dis_u2_susphy_quirk:1;
unsigned dis_enblslpm_quirk:1;
+ unsigned dis_rxdet_inp3_quirk:1;
unsigned tx_de_emphasis_quirk:1;
unsigned tx_de_emphasis:2;
diff --git a/drivers/usb/dwc3/platform_data.h b/drivers/usb/dwc3/platform_data.h
index 2bb4d3a..aaa44db 100644
--- a/drivers/usb/dwc3/platform_data.h
+++ b/drivers/usb/dwc3/platform_data.h
@@ -43,6 +43,7 @@ struct dwc3_platform_data {
unsigned dis_u3_susphy_quirk:1;
unsigned dis_u2_susphy_quirk:1;
unsigned dis_enblslpm_quirk:1;
+ unsigned dis_rxdet_inp3_quirk:1;
unsigned tx_de_emphasis_quirk:1;
unsigned tx_de_emphasis:2;
--
2.6.2.198.g614a2ac
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 2/2] Documentation: dt: dwc3: Add snps,dis_rxdet_inp3_quirk property
2016-03-14 9:10 [PATCH v2 0/2] usb: dwc3: add disable receiver detection in P3 quirk Rajesh Bhagat
2016-03-14 9:10 ` [PATCH v2 1/2] " Rajesh Bhagat
@ 2016-03-14 9:10 ` Rajesh Bhagat
[not found] ` <DB5PR0401MB2024DEBF67F3990558A1D6BBF56B0@DB5PR0401MB2024.eurprd04.prod.outlook.com>
2 siblings, 0 replies; 6+ messages in thread
From: Rajesh Bhagat @ 2016-03-14 9:10 UTC (permalink / raw)
To: balbi
Cc: gregkh, linux-usb, linux-kernel, linux-omap, sriram.dash, Rajesh Bhagat
Add snps,dis_rxdet_inp3_quirk property which disables receiver detection
in PHY P3 power state.
Signed-off-by: Sriram Dash <sriram.dash@nxp.com>
Signed-off-by: Rajesh Bhagat <rajesh.bhagat@nxp.com>
---
Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt
index fb2ad0a..9e546c4 100644
--- a/Documentation/devicetree/bindings/usb/dwc3.txt
+++ b/Documentation/devicetree/bindings/usb/dwc3.txt
@@ -38,6 +38,8 @@ Optional properties:
- snps,dis_u2_susphy_quirk: when set core will disable USB2 suspend phy.
- snps,dis_enblslpm_quirk: when set clears the enblslpm in GUSB2PHYCFG,
disabling the suspend signal to the PHY.
+ - snps,dis_rxdet_inp3_quirk: when set core will disable receiver detection
+ in PHY P3 power state.
- snps,is-utmi-l1-suspend: true when DWC3 asserts output signal
utmi_l1_suspend_n, false when asserts utmi_sleep_n
- snps,hird-threshold: HIRD threshold
--
2.6.2.198.g614a2ac
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v2 0/2] usb: dwc3: add disable receiver detection in P3 quirk
[not found] ` <DB5PR0401MB2024DEBF67F3990558A1D6BBF56B0@DB5PR0401MB2024.eurprd04.prod.outlook.com>
@ 2016-04-18 6:01 ` Rajesh Bhagat
2016-04-18 7:56 ` Felipe Balbi
2016-04-18 6:05 ` Rajesh Bhagat
1 sibling, 1 reply; 6+ messages in thread
From: Rajesh Bhagat @ 2016-04-18 6:01 UTC (permalink / raw)
To: balbi
Cc: gregkh, linux-usb, linux-kernel, linux-omap, Sriram Dash, Rajesh Bhagat
>-----Original Message-----
>From: Rajesh Bhagat [mailto:rajesh.bhagat@nxp.com]
>Sent: Monday, March 14, 2016 2:41 PM
>To: balbi@ti.com
>Cc: gregkh@linuxfoundation.org; linux-usb@vger.kernel.org; linux-
>kernel@vger.kernel.org; linux-omap@vger.kernel.org; Sriram Dash
><sriram.dash@nxp.com>; Rajesh Bhagat <rajesh.bhagat@nxp.com>
>Subject: [PATCH v2 0/2] usb: dwc3: add disable receiver detection in P3
>quirk
>
>Adds disable receiver detection in P3 quirk in DWC3 driver.
>
>Rajesh Bhagat (2):
> usb: dwc3: add disable receiver detection in P3 quirk
> Documentation: dt: dwc3: Add snps,dis_rxdet_inp3_quirk property
>
> Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++
> drivers/usb/dwc3/core.c | 6 ++++++
> drivers/usb/dwc3/core.h | 2 ++
> drivers/usb/dwc3/platform_data.h | 1 +
> 4 files changed, 11 insertions(+)
>
Hello Felipe,
Any comments on above [v2] patches?
Best Regards,
Rajesh Bhagat
>--
>2.6.2.198.g614a2ac
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v2 0/2] usb: dwc3: add disable receiver detection in P3 quirk
[not found] ` <DB5PR0401MB2024DEBF67F3990558A1D6BBF56B0@DB5PR0401MB2024.eurprd04.prod.outlook.com>
2016-04-18 6:01 ` [PATCH v2 0/2] usb: dwc3: add disable receiver detection in P3 quirk Rajesh Bhagat
@ 2016-04-18 6:05 ` Rajesh Bhagat
1 sibling, 0 replies; 6+ messages in thread
From: Rajesh Bhagat @ 2016-04-18 6:05 UTC (permalink / raw)
To: balbi; +Cc: gregkh, linux-usb, linux-kernel, linux-omap, Sriram Dash
> -----Original Message-----
> From: Rajesh Bhagat
> Sent: Monday, April 18, 2016 11:31 AM
> To: 'balbi@ti.com' <balbi@ti.com>
> Cc: 'gregkh@linuxfoundation.org' <gregkh@linuxfoundation.org>; 'linux-
> usb@vger.kernel.org' <linux-usb@vger.kernel.org>; 'linux-kernel@vger.kernel.org'
> <linux-kernel@vger.kernel.org>; 'linux-omap@vger.kernel.org' <linux-
> omap@vger.kernel.org>; Sriram Dash <sriram.dash@nxp.com>; Rajesh Bhagat
> <rajesh.bhagat@nxp.com>
> Subject: RE: [PATCH v2 0/2] usb: dwc3: add disable receiver detection in P3 quirk
>
> >-----Original Message-----
> >From: Rajesh Bhagat [mailto:rajesh.bhagat@nxp.com]
> >Sent: Monday, March 14, 2016 2:41 PM
> >To: balbi@ti.com
> >Cc: gregkh@linuxfoundation.org; linux-usb@vger.kernel.org; linux-
> >kernel@vger.kernel.org; linux-omap@vger.kernel.org; Sriram Dash
> ><sriram.dash@nxp.com>; Rajesh Bhagat <rajesh.bhagat@nxp.com>
> >Subject: [PATCH v2 0/2] usb: dwc3: add disable receiver detection in P3
> >quirk
> >
> >Adds disable receiver detection in P3 quirk in DWC3 driver.
> >
> >Rajesh Bhagat (2):
> > usb: dwc3: add disable receiver detection in P3 quirk
> > Documentation: dt: dwc3: Add snps,dis_rxdet_inp3_quirk property
> >
> > Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++
> > drivers/usb/dwc3/core.c | 6 ++++++
> > drivers/usb/dwc3/core.h | 2 ++
> > drivers/usb/dwc3/platform_data.h | 1 +
> > 4 files changed, 11 insertions(+)
> >
>
> Hello Felipe,
>
> Any comments on above [v2] patches?
>
> Best Regards,
> Rajesh Bhagat
>
Just realized Felipe's email id has changed, Resending.
> >--
> >2.6.2.198.g614a2ac
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v2 0/2] usb: dwc3: add disable receiver detection in P3 quirk
2016-04-18 6:01 ` [PATCH v2 0/2] usb: dwc3: add disable receiver detection in P3 quirk Rajesh Bhagat
@ 2016-04-18 7:56 ` Felipe Balbi
0 siblings, 0 replies; 6+ messages in thread
From: Felipe Balbi @ 2016-04-18 7:56 UTC (permalink / raw)
To: Rajesh Bhagat, balbi
Cc: gregkh, linux-usb, linux-kernel, linux-omap, Sriram Dash, Rajesh Bhagat
[-- Attachment #1: Type: text/plain, Size: 1323 bytes --]
Hi,
Rajesh Bhagat <rajesh.bhagat@nxp.com> writes:
>>-----Original Message-----
>>From: Rajesh Bhagat [mailto:rajesh.bhagat@nxp.com]
>>Sent: Monday, March 14, 2016 2:41 PM
>>To: balbi@ti.com
>>Cc: gregkh@linuxfoundation.org; linux-usb@vger.kernel.org; linux-
>>kernel@vger.kernel.org; linux-omap@vger.kernel.org; Sriram Dash
>><sriram.dash@nxp.com>; Rajesh Bhagat <rajesh.bhagat@nxp.com>
>>Subject: [PATCH v2 0/2] usb: dwc3: add disable receiver detection in P3
>>quirk
>>
>>Adds disable receiver detection in P3 quirk in DWC3 driver.
>>
>>Rajesh Bhagat (2):
>> usb: dwc3: add disable receiver detection in P3 quirk
>> Documentation: dt: dwc3: Add snps,dis_rxdet_inp3_quirk property
>>
>> Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++
>> drivers/usb/dwc3/core.c | 6 ++++++
>> drivers/usb/dwc3/core.h | 2 ++
>> drivers/usb/dwc3/platform_data.h | 1 +
>> 4 files changed, 11 insertions(+)
>>
>
> Hello Felipe,
>
> Any comments on above [v2] patches?
>
https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=testing/next&id=ddf332eb6a5379c3f4bcade6760ae41bcd8f2202
https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=testing/next&id=bdeb03b4ed887a36595fc8ccdd04f82e718e9ab4
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-04-18 7:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-14 9:10 [PATCH v2 0/2] usb: dwc3: add disable receiver detection in P3 quirk Rajesh Bhagat
2016-03-14 9:10 ` [PATCH v2 1/2] " Rajesh Bhagat
2016-03-14 9:10 ` [PATCH v2 2/2] Documentation: dt: dwc3: Add snps,dis_rxdet_inp3_quirk property Rajesh Bhagat
[not found] ` <DB5PR0401MB2024DEBF67F3990558A1D6BBF56B0@DB5PR0401MB2024.eurprd04.prod.outlook.com>
2016-04-18 6:01 ` [PATCH v2 0/2] usb: dwc3: add disable receiver detection in P3 quirk Rajesh Bhagat
2016-04-18 7:56 ` Felipe Balbi
2016-04-18 6:05 ` Rajesh Bhagat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®