* [PATCH] powerpc/smp: parse_thread_groups() return error on missing property
@ 2026-11-14 7:38 John Ogness
0 siblings, 0 replies; only message in thread
From: John Ogness @ 2026-11-14 7:38 UTC (permalink / raw)
To: Madhavan Srinivasan
Cc: Michael Ellerman, Nicholas Piggin, Christophe Leroy (CS GROUP),
Ritesh Harjani (IBM),
Shrikanth Hegde, Sebastian Andrzej Siewior, linuxppc-dev,
linux-kernel
parse_thread_groups() is supposed to return -EINVAL if the property
does not exist and -ENODATA if property does not have a value.
However, it is currently assuming it exists and blindly calling
kzalloc_objs() with whatever of_property_count_u32_elems() returns.
Since of_property_count_u32_elems() returns exactly these same error
values in those cases, simply return with the returned error value.
Signed-off-by: John Ogness <john.ogness@linutronix.de>
---
arch/powerpc/kernel/smp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
index 7a25eaa59e626..58824f5f4c800 100644
--- a/arch/powerpc/kernel/smp.c
+++ b/arch/powerpc/kernel/smp.c
@@ -824,6 +824,8 @@ static int parse_thread_groups(struct device_node *dn,
int i = 0;
count = of_property_count_u32_elems(dn, "ibm,thread-groups");
+ if (count < 0)
+ return count;
thread_group_array = kzalloc_objs(u32, count);
if (!thread_group_array)
return -ENOMEM;
--
2.47.3
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-11-14 7:38 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-14 7:38 [PATCH] powerpc/smp: parse_thread_groups() return error on missing property John Ogness
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®