mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] docs: ABI: sysfs-class-firmware-attributes: use literal blocks for console commands
@ 2026-09-23  2:49 Randy Dunlap
  2026-09-23 12:31 ` Mark Pearson
  2026-09-26 15:47 ` Jonathan Corbet
  0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2026-09-23  2:49 UTC (permalink / raw)
  To: linux-kernel
  Cc: Randy Dunlap, Mark Pearson, Hans de Goede, Ilpo Järvinen,
	platform-driver-x86, Jonathan Corbet, Shuah Khan, linux-doc

Use a literal block for console I/O so that the lines aren't merged
together in the produced output.

Also correct some punctuation.

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Mark Pearson <mpearson-lenovo@squebb.ca>
Cc: Hans de Goede <hansg@kernel.org>
Cc: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Cc: platform-driver-x86@vger.kernel.org
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Shuah Khan <skhan@linuxfoundation.org>
Cc: linux-doc@vger.kernel.org

 Documentation/ABI/testing/sysfs-class-firmware-attributes |   21 +++++-----
 1 file changed, 12 insertions(+), 9 deletions(-)

--- linux-next-20260921.orig/Documentation/ABI/testing/sysfs-class-firmware-attributes
+++ linux-next-20260921/Documentation/ABI/testing/sysfs-class-firmware-attributes
@@ -397,22 +397,25 @@ Description:
 		unlimited attributes.
 
 		Read the attribute to check what save mode is enabled (single or bulk).
-		E.g:
-		# cat /sys/class/firmware-attributes/thinklmi/attributes/save_settings
-		single
+		E.g::
+
+		  # cat /sys/class/firmware-attributes/thinklmi/attributes/save_settings
+		  single
 
 		Write the attribute with 'bulk' to enable bulk save mode.
-		Write the attribute with 'single' to enable saving, after every attribute set.
+		Write the attribute with 'single' to enable saving after every attribute set.
 		The default setting is single mode.
-		E.g:
-		# echo bulk > /sys/class/firmware-attributes/thinklmi/attributes/save_settings
+		E.g::
+
+		  # echo bulk > /sys/class/firmware-attributes/thinklmi/attributes/save_settings
 
 		When in bulk mode write 'save' to trigger a save of all currently modified attributes.
-		Note, once a save has been triggered, in bulk mode, attributes can no longer be set and
+		Note, once a save has been triggered in bulk mode, attributes can no longer be set and
 		will return a permissions error. This is to prevent users hitting the 48+ save limitation
 		(which requires entering the BIOS to clear the error condition)
-		E.g:
-		# echo save > /sys/class/firmware-attributes/thinklmi/attributes/save_settings
+		E.g::
+
+		  # echo save > /sys/class/firmware-attributes/thinklmi/attributes/save_settings
 
 What:		/sys/class/firmware-attributes/*/attributes/debug_cmd
 Date:		July 2021

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] docs: ABI: sysfs-class-firmware-attributes: use literal blocks for console commands
  2026-09-23  2:49 [PATCH] docs: ABI: sysfs-class-firmware-attributes: use literal blocks for console commands Randy Dunlap
@ 2026-09-23 12:31 ` Mark Pearson
  2026-09-26 15:47 ` Jonathan Corbet
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Pearson @ 2026-09-23 12:31 UTC (permalink / raw)
  To: Randy Dunlap, linux-kernel
  Cc: Hans de Goede, Ilpo Järvinen, platform-driver-x86,
	Jonathan Corbet, Shuah Khan, linux-doc



On Tue, Sep 22, 2026, at 10:49 PM, Randy Dunlap wrote:
> Use a literal block for console I/O so that the lines aren't merged
> together in the produced output.
>
> Also correct some punctuation.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> Cc: Mark Pearson <mpearson-lenovo@squebb.ca>
> Cc: Hans de Goede <hansg@kernel.org>
> Cc: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Cc: platform-driver-x86@vger.kernel.org
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: Shuah Khan <skhan@linuxfoundation.org>
> Cc: linux-doc@vger.kernel.org
>
>  Documentation/ABI/testing/sysfs-class-firmware-attributes |   21 +++++-----
>  1 file changed, 12 insertions(+), 9 deletions(-)
>
> --- 
> linux-next-20260921.orig/Documentation/ABI/testing/sysfs-class-firmware-attributes
> +++ 
> linux-next-20260921/Documentation/ABI/testing/sysfs-class-firmware-attributes
> @@ -397,22 +397,25 @@ Description:
>  		unlimited attributes.
> 
>  		Read the attribute to check what save mode is enabled (single or bulk).
> -		E.g:
> -		# cat /sys/class/firmware-attributes/thinklmi/attributes/save_settings
> -		single
> +		E.g::
> +
> +		  # cat /sys/class/firmware-attributes/thinklmi/attributes/save_settings
> +		  single
> 
>  		Write the attribute with 'bulk' to enable bulk save mode.
> -		Write the attribute with 'single' to enable saving, after every 
> attribute set.
> +		Write the attribute with 'single' to enable saving after every 
> attribute set.
>  		The default setting is single mode.
> -		E.g:
> -		# echo bulk > 
> /sys/class/firmware-attributes/thinklmi/attributes/save_settings
> +		E.g::
> +
> +		  # echo bulk > 
> /sys/class/firmware-attributes/thinklmi/attributes/save_settings
> 
>  		When in bulk mode write 'save' to trigger a save of all currently 
> modified attributes.
> -		Note, once a save has been triggered, in bulk mode, attributes can 
> no longer be set and
> +		Note, once a save has been triggered in bulk mode, attributes can no 
> longer be set and
>  		will return a permissions error. This is to prevent users hitting 
> the 48+ save limitation
>  		(which requires entering the BIOS to clear the error condition)
> -		E.g:
> -		# echo save > 
> /sys/class/firmware-attributes/thinklmi/attributes/save_settings
> +		E.g::
> +
> +		  # echo save > 
> /sys/class/firmware-attributes/thinklmi/attributes/save_settings
> 
>  What:		/sys/class/firmware-attributes/*/attributes/debug_cmd
>  Date:		July 2021

Looks good to me
Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>

Mark

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] docs: ABI: sysfs-class-firmware-attributes: use literal blocks for console commands
  2026-09-23  2:49 [PATCH] docs: ABI: sysfs-class-firmware-attributes: use literal blocks for console commands Randy Dunlap
  2026-09-23 12:31 ` Mark Pearson
@ 2026-09-26 15:47 ` Jonathan Corbet
  1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Corbet @ 2026-09-26 15:47 UTC (permalink / raw)
  To: Randy Dunlap, linux-kernel
  Cc: Randy Dunlap, Mark Pearson, Hans de Goede, Ilpo Järvinen,
	platform-driver-x86, Shuah Khan, linux-doc

Randy Dunlap <rdunlap@infradead.org> writes:

> Use a literal block for console I/O so that the lines aren't merged
> together in the produced output.
>
> Also correct some punctuation.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> Cc: Mark Pearson <mpearson-lenovo@squebb.ca>
> Cc: Hans de Goede <hansg@kernel.org>
> Cc: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Cc: platform-driver-x86@vger.kernel.org
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: Shuah Khan <skhan@linuxfoundation.org>
> Cc: linux-doc@vger.kernel.org
>
>  Documentation/ABI/testing/sysfs-class-firmware-attributes |   21 +++++-----
>  1 file changed, 12 insertions(+), 9 deletions(-)

Applied, thanks.

jon

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-09-26 15:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-23  2:49 [PATCH] docs: ABI: sysfs-class-firmware-attributes: use literal blocks for console commands Randy Dunlap
2026-09-23 12:31 ` Mark Pearson
2026-09-26 15:47 ` Jonathan Corbet

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®