* [PATCH net-next] vxlan: remove redundant conversion of vni in vxlan_nl2conf
@ 2025-07-22 9:30 Wang Liang
2025-07-22 9:19 ` Nikolay Aleksandrov
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Wang Liang @ 2025-07-22 9:30 UTC (permalink / raw)
To: andrew+netdev, davem, edumazet, kuba, pabeni, razor, idosch,
petrm, menglong8.dong
Cc: yuehaibing, zhangchangzhong, wangliang74, netdev, linux-kernel
The IFLA_VXLAN_ID data has been converted to local variable vni in
vxlan_nl2conf(), there is no need to do it again when set conf->vni.
Signed-off-by: Wang Liang <wangliang74@huawei.com>
---
drivers/net/vxlan/vxlan_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c
index 97792de896b7..77dbfe9a6b13 100644
--- a/drivers/net/vxlan/vxlan_core.c
+++ b/drivers/net/vxlan/vxlan_core.c
@@ -4036,7 +4036,7 @@ static int vxlan_nl2conf(struct nlattr *tb[], struct nlattr *data[],
NL_SET_ERR_MSG_ATTR(extack, tb[IFLA_VXLAN_ID], "Cannot change VNI");
return -EOPNOTSUPP;
}
- conf->vni = cpu_to_be32(nla_get_u32(data[IFLA_VXLAN_ID]));
+ conf->vni = vni;
}
if (data[IFLA_VXLAN_GROUP]) {
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next] vxlan: remove redundant conversion of vni in vxlan_nl2conf
2025-07-22 9:30 [PATCH net-next] vxlan: remove redundant conversion of vni in vxlan_nl2conf Wang Liang
@ 2025-07-22 9:19 ` Nikolay Aleksandrov
2025-07-22 9:38 ` Petr Machata
2025-07-24 2:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Nikolay Aleksandrov @ 2025-07-22 9:19 UTC (permalink / raw)
To: Wang Liang, andrew+netdev, davem, edumazet, kuba, pabeni, idosch,
petrm, menglong8.dong
Cc: yuehaibing, zhangchangzhong, netdev, linux-kernel
On 7/22/25 12:30, Wang Liang wrote:
> The IFLA_VXLAN_ID data has been converted to local variable vni in
> vxlan_nl2conf(), there is no need to do it again when set conf->vni.
>
> Signed-off-by: Wang Liang <wangliang74@huawei.com>
> ---
> drivers/net/vxlan/vxlan_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c
> index 97792de896b7..77dbfe9a6b13 100644
> --- a/drivers/net/vxlan/vxlan_core.c
> +++ b/drivers/net/vxlan/vxlan_core.c
> @@ -4036,7 +4036,7 @@ static int vxlan_nl2conf(struct nlattr *tb[], struct nlattr *data[],
> NL_SET_ERR_MSG_ATTR(extack, tb[IFLA_VXLAN_ID], "Cannot change VNI");
> return -EOPNOTSUPP;
> }
> - conf->vni = cpu_to_be32(nla_get_u32(data[IFLA_VXLAN_ID]));
> + conf->vni = vni;
> }
>
> if (data[IFLA_VXLAN_GROUP]) {
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next] vxlan: remove redundant conversion of vni in vxlan_nl2conf
2025-07-22 9:30 [PATCH net-next] vxlan: remove redundant conversion of vni in vxlan_nl2conf Wang Liang
2025-07-22 9:19 ` Nikolay Aleksandrov
@ 2025-07-22 9:38 ` Petr Machata
2025-07-24 2:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Petr Machata @ 2025-07-22 9:38 UTC (permalink / raw)
To: Wang Liang
Cc: andrew+netdev, davem, edumazet, kuba, pabeni, razor, idosch,
petrm, menglong8.dong, yuehaibing, zhangchangzhong, netdev,
linux-kernel
Wang Liang <wangliang74@huawei.com> writes:
> The IFLA_VXLAN_ID data has been converted to local variable vni in
> vxlan_nl2conf(), there is no need to do it again when set conf->vni.
>
> Signed-off-by: Wang Liang <wangliang74@huawei.com>
Reviewed-by: Petr Machata <petrm@nvidia.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] vxlan: remove redundant conversion of vni in vxlan_nl2conf
2025-07-22 9:30 [PATCH net-next] vxlan: remove redundant conversion of vni in vxlan_nl2conf Wang Liang
2025-07-22 9:19 ` Nikolay Aleksandrov
2025-07-22 9:38 ` Petr Machata
@ 2025-07-24 2:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-07-24 2:00 UTC (permalink / raw)
To: Wang Liang
Cc: andrew+netdev, davem, edumazet, kuba, pabeni, razor, idosch,
petrm, menglong8.dong, yuehaibing, zhangchangzhong, netdev,
linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 22 Jul 2025 17:30:49 +0800 you wrote:
> The IFLA_VXLAN_ID data has been converted to local variable vni in
> vxlan_nl2conf(), there is no need to do it again when set conf->vni.
>
> Signed-off-by: Wang Liang <wangliang74@huawei.com>
> ---
> drivers/net/vxlan/vxlan_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [net-next] vxlan: remove redundant conversion of vni in vxlan_nl2conf
https://git.kernel.org/netdev/net-next/c/918c675b208d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-07-24 2:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-07-22 9:30 [PATCH net-next] vxlan: remove redundant conversion of vni in vxlan_nl2conf Wang Liang
2025-07-22 9:19 ` Nikolay Aleksandrov
2025-07-22 9:38 ` Petr Machata
2025-07-24 2:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®