mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] MAINTAINERS: add missing maintainers for Sound drivers
@ 2025-01-06  6:01 Kuninori Morimoto
  2025-01-06 12:34 ` Mark Brown
  0 siblings, 1 reply; 5+ messages in thread
From: Kuninori Morimoto @ 2025-01-06  6:01 UTC (permalink / raw)
  To: Mark Brown; +Cc: Linux-Kernel, linux-sound

Mark Brown will take the patch. Add his name.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 27d9d68675b2e..e453c6ad9314c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -19868,6 +19868,7 @@ F:	Documentation/devicetree/bindings/sound/renesas,idt821034.yaml
 F:	sound/soc/codecs/idt821034.c
 
 RENESAS R-CAR & FSI AUDIO (ASoC) DRIVERS
+M:	Mark Brown <broonie@kernel.org>
 M:	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
 L:	linux-sound@vger.kernel.org
 L:	linux-renesas-soc@vger.kernel.org
@@ -21991,6 +21992,7 @@ W:	https://github.com/thesofproject/linux/
 F:	sound/soc/sof/
 
 SOUND - GENERIC SOUND CARD (Simple-Audio-Card, Audio-Graph-Card)
+M:	Mark Brown <broonie@kernel.org>
 M:	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
 S:	Supported
 L:	linux-sound@vger.kernel.org
-- 
2.43.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] MAINTAINERS: add missing maintainers for Sound drivers
  2025-01-06  6:01 [PATCH] MAINTAINERS: add missing maintainers for Sound drivers Kuninori Morimoto
@ 2025-01-06 12:34 ` Mark Brown
  2025-01-06 23:43   ` Kuninori Morimoto
  0 siblings, 1 reply; 5+ messages in thread
From: Mark Brown @ 2025-01-06 12:34 UTC (permalink / raw)
  To: Kuninori Morimoto; +Cc: Linux-Kernel, linux-sound

[-- Attachment #1: Type: text/plain, Size: 451 bytes --]

On Mon, Jan 06, 2025 at 06:01:25AM +0000, Kuninori Morimoto wrote:
> Mark Brown will take the patch. Add his name.

>  RENESAS R-CAR & FSI AUDIO (ASoC) DRIVERS
> +M:	Mark Brown <broonie@kernel.org>
>  M:	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

It's fine not to list me for individual drivers, things like
get_maintainers will wrap in all the upper level maintainers
automatically and I don't actually know anything about R-Car hardware.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] MAINTAINERS: add missing maintainers for Sound drivers
  2025-01-06 12:34 ` Mark Brown
@ 2025-01-06 23:43   ` Kuninori Morimoto
  2025-01-07 16:24     ` Mark Brown
  0 siblings, 1 reply; 5+ messages in thread
From: Kuninori Morimoto @ 2025-01-06 23:43 UTC (permalink / raw)
  To: Mark Brown; +Cc: Linux-Kernel, linux-sound


Hi Mark

> >  RENESAS R-CAR & FSI AUDIO (ASoC) DRIVERS
> > +M:	Mark Brown <broonie@kernel.org>
> >  M:	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> It's fine not to list me for individual drivers, things like
> get_maintainers will wrap in all the upper level maintainers
> automatically

Thanks.

Indeed no need to add your name for R-Car driver.
But I noticed get_maintainers doesn't indicate your name for below header
which is used for Simple Card / Audio Graph Card.

	include/sound/simple_card*

It seems under include/sound/ is divided into smaller parts.
I guess we want to have this instead ?

--------------------------
diff --git a/MAINTAINERS b/MAINTAINERS
index 27d9d68675b2e..9a21890bb6fce 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -21964,9 +21964,7 @@ T:      git git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
 F:     Documentation/devicetree/bindings/sound/
 F:     Documentation/sound/soc/
 F:     include/dt-bindings/sound/
-F:     include/sound/soc*
-F:     include/sound/sof.h
-F:     include/sound/sof/
+F:     include/sound/
 F:     include/trace/events/sof*.h
 F:     include/uapi/sound/asoc.h
 F:     sound/soc/
--------------------------

Thank you for your help !!

Best regards
---
Kuninori Morimoto

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] MAINTAINERS: add missing maintainers for Sound drivers
  2025-01-06 23:43   ` Kuninori Morimoto
@ 2025-01-07 16:24     ` Mark Brown
  2025-01-07 23:23       ` Kuninori Morimoto
  0 siblings, 1 reply; 5+ messages in thread
From: Mark Brown @ 2025-01-07 16:24 UTC (permalink / raw)
  To: Kuninori Morimoto; +Cc: Linux-Kernel, linux-sound

[-- Attachment #1: Type: text/plain, Size: 1295 bytes --]

On Mon, Jan 06, 2025 at 11:43:59PM +0000, Kuninori Morimoto wrote:

> > >  RENESAS R-CAR & FSI AUDIO (ASoC) DRIVERS
> > > +M:	Mark Brown <broonie@kernel.org>
> > >  M:	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

> > It's fine not to list me for individual drivers, things like
> > get_maintainers will wrap in all the upper level maintainers
> > automatically

> Indeed no need to add your name for R-Car driver.
> But I noticed get_maintainers doesn't indicate your name for below header
> which is used for Simple Card / Audio Graph Card.

> 	include/sound/simple_card*

> It seems under include/sound/ is divided into smaller parts.
> I guess we want to have this instead ?

>  F:     Documentation/sound/soc/
>  F:     include/dt-bindings/sound/
> -F:     include/sound/soc*
> -F:     include/sound/sof.h
> -F:     include/sound/sof/
> +F:     include/sound/

We could do, though that'd also pull in generic ALSA stuff that's not
relevant to me (which is why it's the specific patterns at the minute).
TBH I get copied on enough stuff and the volume is low enough that it's
not the end of the world.  The other, more specific, option would be to
add the individual files.  It'd also be fine to list me for the generic
cards if you like, it was mainly R-Car that didn't seem right.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] MAINTAINERS: add missing maintainers for Sound drivers
  2025-01-07 16:24     ` Mark Brown
@ 2025-01-07 23:23       ` Kuninori Morimoto
  0 siblings, 0 replies; 5+ messages in thread
From: Kuninori Morimoto @ 2025-01-07 23:23 UTC (permalink / raw)
  To: Mark Brown; +Cc: Linux-Kernel, linux-sound


Hi Mark

> We could do, though that'd also pull in generic ALSA stuff that's not
> relevant to me (which is why it's the specific patterns at the minute).
> TBH I get copied on enough stuff and the volume is low enough that it's
> not the end of the world.  The other, more specific, option would be to
> add the individual files.  It'd also be fine to list me for the generic
> cards if you like, it was mainly R-Car that didn't seem right.

OK, I see. Thank you for clarify the situation.
I think adding your name to Generic Card is more simple.
Will post the patch, soon.

Thank you for your help !!

Best regards
---
Kuninori Morimoto

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-01-07 23:23 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-01-06  6:01 [PATCH] MAINTAINERS: add missing maintainers for Sound drivers Kuninori Morimoto
2025-01-06 12:34 ` Mark Brown
2025-01-06 23:43   ` Kuninori Morimoto
2025-01-07 16:24     ` Mark Brown
2025-01-07 23:23       ` Kuninori Morimoto

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®