mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Bjørn Mork" <bjorn@mork.no>
To: Kristian Evensen <kristian.evensen@gmail.com>
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] qmi_wwan: Add missing skb_reset_mac_header-call
Date: Tue, 07 Nov 2017 14:02:53 +0100	[thread overview]
Message-ID: <87mv3ynsw2.fsf@miraculix.mork.no> (raw)
In-Reply-To: <20171107124756.3029-1-kristian.evensen@gmail.com> (Kristian Evensen's message of "Tue, 7 Nov 2017 13:47:56 +0100")

Kristian Evensen <kristian.evensen@gmail.com> writes:

> When we receive a packet on a QMI device in raw IP mode, we should call
> skb_reset_mac_header() to ensure that skb->mac_header contains a valid
> offset in the packet. While it shouldn't really matter, the packets have
> no MAC header and the interface is configured as-such, it seems certain
> parts of the network stack expects a "good" value in skb->mac_header.

Thanks.  Yes, I see that the tun driver also does this.

Acked-by: Bjørn Mork <bjorn@mork.no>

And his should probably go to stable as well? with a

Fixes: 32f7adf633b9 ("net: qmi_wwan: support "raw IP" mode")

  reply	other threads:[~2017-11-07 13:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-07 12:47 Kristian Evensen
2017-11-07 13:02 ` Bjørn Mork [this message]
2017-11-07 14:32   ` Kristian Evensen
2017-11-08  7:12 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mv3ynsw2.fsf@miraculix.mork.no \
    --to=bjorn@mork.no \
    --cc=kristian.evensen@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®