mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Zhao Qiang <qiang.zhao@nxp.com>, oss@buserror.net
Cc: valentin.longchamp@keymile.com, linuxppc-dev@lists.ozlabs.org,
	linux-kernel@vger.kernel.org, Zhao Qiang <qiang.zhao@nxp.com>
Subject: Re: [PATCH] qe: fix compile issue for arm64
Date: Fri, 21 Jul 2017 16:34:23 +1000	[thread overview]
Message-ID: <87mv7ye1sg.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <1500603550-5567-1-git-send-email-qiang.zhao@nxp.com>

Zhao Qiang <qiang.zhao@nxp.com> writes:

> Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> ---
>  drivers/soc/fsl/qe/qe.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/soc/fsl/qe/qe.c b/drivers/soc/fsl/qe/qe.c
> index 2ef6fc6..d48fa4a 100644
> --- a/drivers/soc/fsl/qe/qe.c
> +++ b/drivers/soc/fsl/qe/qe.c
> @@ -229,7 +229,9 @@ int qe_setbrg(enum qe_clock brg, unsigned int rate, unsigned int multiplier)
>  	/* Errata QE_General4, which affects some MPC832x and MPC836x SOCs, says
>  	   that the BRG divisor must be even if you're not using divide-by-16
>  	   mode. */
> +#ifdef CONFIG_PPC
>  	if (pvr_version_is(PVR_VER_836x) || pvr_version_is(PVR_VER_832x))
> +#endif
>  		if (!div16 && (divisor & 1) && (divisor > 3))
>  			divisor++;

Are you sure that's what you want to do on arm64 ?

cheers

  reply	other threads:[~2017-07-21  6:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-21  2:19 Zhao Qiang
2017-07-21  6:34 ` Michael Ellerman [this message]
2017-07-24  2:09   ` Qiang Zhao
2017-07-24  3:32     ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mv7ye1sg.fsf@concordia.ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=oss@buserror.net \
    --cc=qiang.zhao@nxp.com \
    --cc=valentin.longchamp@keymile.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®