Re: [PATCH 3/3] drm/vc4: Add support for dma-buf fencing.

[Eric Anholt <eric@anholt.net>]

[-- Attachment #1: Type: text/plain, Size: 1141 bytes --]

Chris Wilson <chris@chris-wilson.co.uk> writes:

> On Mon, Apr 10, 2017 at 06:44:14PM -0700, Eric Anholt wrote:
>> This is needed for proper synchronization with display on another DRM
>> device (pl111 or tinydrm) with buffers produced by vc4 V3D.  Fixes the
>> new igt vc4_dmabuf_poll testcase, and rendering of one of the glmark2
>> desktop tests on pl111+vc4.
>> 
>> This doesn't yet introduce waits on other device's fences before vc4's
>> rendering/display, because I don't have testcases for them.
>> 
>> Signed-off-by: Eric Anholt <eric@anholt.net>
>> Cc: Gustavo Padovan <gustavo.padovan@collabora.com>
>> ---
>> +static void vc4_fence_release(struct dma_fence *fence)
>> +{
>> +	struct vc4_fence *f = to_vc4_fence(fence);
>> +
>> +	kfree_rcu(f, base.rcu);
>> +}
>
> Unless you have a plan to do more here, looks like you can just use
> the default dma_fence_free as the release callback.
> -Chris

Yeah, this pattern came from etnaviv/msm (which I had used as
reference), who both put their .base second.  I wonder if they would
want to flip the order of their fields and drop their fence_release,
too.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]