Re: [PATCH 3/3] drm/vc4: Add support for dma-buf fencing.

[Eric Anholt <eric@anholt.net>]

[-- Attachment #1: Type: text/plain, Size: 940 bytes --]

Daniel Vetter <daniel@ffwll.ch> writes:

> On Mon, Apr 10, 2017 at 06:44:14PM -0700, Eric Anholt wrote:
>> This is needed for proper synchronization with display on another DRM
>> device (pl111 or tinydrm) with buffers produced by vc4 V3D.  Fixes the
>> new igt vc4_dmabuf_poll testcase, and rendering of one of the glmark2
>> desktop tests on pl111+vc4.
>> 
>> This doesn't yet introduce waits on other device's fences before vc4's
>> rendering/display, because I don't have testcases for them.
>> 
>> Signed-off-by: Eric Anholt <eric@anholt.net>
>> Cc: Gustavo Padovan <gustavo.padovan@collabora.com>
>
> So not sure I didn't look hard enough or why exactly, but I didn't find
> anything like ->prepare_fb as implemented in e.g. drm_fb_cma_prepare_fb().
> Where is that? Otherwise looks good to me.

Yeah, I need to sort that out for vc4 as a consumer of busy buffers
still.  This patch just does vc4 as the producer.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]