From: Peter Korsgaard <peter@korsgaard.com>
To: Michal Simek <michal.simek@xilinx.com>
Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org, arnd@arndb.de,
Peter Korsgaard <jacmet@sunsite.dk>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
Jiri Slaby <jslaby@suse.cz>
Subject: Re: [PATCH 2/2] tty: serial: uartlite: Remove .owner field for driver
Date: Sun, 17 Aug 2014 00:23:06 +0200 [thread overview]
Message-ID: <87mwb4ysz9.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <4af7dab0dcc8e681b14a5167826e65fb146c5040.1407930818.git.michal.simek@xilinx.com> (Michal Simek's message of "Wed, 13 Aug 2014 13:53:43 +0200")
>>>>> "Michal" == Michal Simek <michal.simek@xilinx.com> writes:
> There is no need to init .owner field.
> Based on the patch from Peter Griffin <peter.griffin@linaro.org>
> "mmc: remove .owner field for drivers using module_platform_driver"
> This patch removes the superflous .owner field for drivers which
> use the module_platform_driver API, as this is overriden in
> platform_driver_register anyway."
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
It would be good with a reference to the commit adding this to
platform_driver_register (9447057eaff8) - But Ok.
Acked-by: Peter Korsgaard <peter@korsgaard.com>
> drivers/tty/serial/uartlite.c | 1 -
> 1 file changed, 1 deletion(-)
> diff --git a/drivers/tty/serial/uartlite.c b/drivers/tty/serial/uartlite.c
> index 9fc22f40796e..189f52e3111f 100644
> --- a/drivers/tty/serial/uartlite.c
> +++ b/drivers/tty/serial/uartlite.c
> @@ -665,7 +665,6 @@ static struct platform_driver ulite_platform_driver = {
> .probe = ulite_probe,
> .remove = ulite_remove,
> .driver = {
> - .owner = THIS_MODULE,
> .name = "uartlite",
> .of_match_table = of_match_ptr(ulite_of_match),
> },
> --
> 1.8.2.3
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2014-08-16 22:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 11:53 [PATCH 1/2] tty: serial: xuartps: " Michal Simek
2014-08-13 11:53 ` [PATCH 2/2] tty: serial: uartlite: " Michal Simek
2014-08-16 22:23 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mwb4ysz9.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=arnd@arndb.de \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=jacmet@sunsite.dk \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®