[PATCH 1/2] tty: serial: xuartps: Remove .owner field for driver

[PATCH 1/2] tty: serial: xuartps: Remove .owner field for driver

[Michal Simek]

[-- Attachment #1: Type: text/plain, Size: 969 bytes --]

There is no need to init .owner field.

Based on the patch from Peter Griffin <peter.griffin@linaro.org>
"mmc: remove .owner field for drivers using module_platform_driver"

This patch removes the superflous .owner field for drivers which
use the module_platform_driver API, as this is overriden in
platform_driver_register anyway."

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 drivers/tty/serial/xilinx_uartps.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
index 01951d27cc03..c3c252db8b61 100644
--- a/drivers/tty/serial/xilinx_uartps.c
+++ b/drivers/tty/serial/xilinx_uartps.c
@@ -1428,7 +1428,6 @@ static struct platform_driver cdns_uart_platform_driver = {
 	.probe   = cdns_uart_probe,
 	.remove  = cdns_uart_remove,
 	.driver  = {
-		.owner = THIS_MODULE,
 		.name = CDNS_UART_NAME,
 		.of_match_table = cdns_uart_of_match,
 		.pm = &cdns_uart_dev_pm_ops,
--
1.8.2.3


[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

[PATCH 2/2] tty: serial: uartlite: Remove .owner field for driver

[Michal Simek]

[-- Attachment #1: Type: text/plain, Size: 906 bytes --]

There is no need to init .owner field.

Based on the patch from Peter Griffin <peter.griffin@linaro.org>
"mmc: remove .owner field for drivers using module_platform_driver"

This patch removes the superflous .owner field for drivers which
use the module_platform_driver API, as this is overriden in
platform_driver_register anyway."

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 drivers/tty/serial/uartlite.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/tty/serial/uartlite.c b/drivers/tty/serial/uartlite.c
index 9fc22f40796e..189f52e3111f 100644
--- a/drivers/tty/serial/uartlite.c
+++ b/drivers/tty/serial/uartlite.c
@@ -665,7 +665,6 @@ static struct platform_driver ulite_platform_driver = {
 	.probe = ulite_probe,
 	.remove = ulite_remove,
 	.driver = {
-		.owner = THIS_MODULE,
 		.name  = "uartlite",
 		.of_match_table = of_match_ptr(ulite_of_match),
 	},
--
1.8.2.3


[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH 2/2] tty: serial: uartlite: Remove .owner field for driver

[Peter Korsgaard]

>>>>> "Michal" == Michal Simek <michal.simek@xilinx.com> writes:

 > There is no need to init .owner field.
 > Based on the patch from Peter Griffin <peter.griffin@linaro.org>
 > "mmc: remove .owner field for drivers using module_platform_driver"

 > This patch removes the superflous .owner field for drivers which
 > use the module_platform_driver API, as this is overriden in
 > platform_driver_register anyway."

 > Signed-off-by: Michal Simek <michal.simek@xilinx.com>

It would be good with a reference to the commit adding this to
platform_driver_register (9447057eaff8) - But Ok.

Acked-by: Peter Korsgaard <peter@korsgaard.com>

 >  drivers/tty/serial/uartlite.c | 1 -
 >  1 file changed, 1 deletion(-)

 > diff --git a/drivers/tty/serial/uartlite.c b/drivers/tty/serial/uartlite.c
 > index 9fc22f40796e..189f52e3111f 100644
 > --- a/drivers/tty/serial/uartlite.c
 > +++ b/drivers/tty/serial/uartlite.c
 > @@ -665,7 +665,6 @@ static struct platform_driver ulite_platform_driver = {
 >  	.probe = ulite_probe,
 >  	.remove = ulite_remove,
 >  	.driver = {
 > -		.owner = THIS_MODULE,
 >  		.name  = "uartlite",
 >  		.of_match_table = of_match_ptr(ulite_of_match),
 >  	},
 > --
 > 1.8.2.3


-- 
Bye, Peter Korsgaard