From: Luis Henriques <luis@igalia.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
Chen Linxuan <me@black-desk.cn>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
fuse-devel@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org,
Matt Harvey <mharvey@jumptrading.com>,
kernel-dev@igalia.com
Subject: Re: [RFC PATCH v4 1/8] Documentation: fuse: add document on caches being used by FUSE
Date: Fri, 18 Sep 2026 10:16:26 +0100 [thread overview]
Message-ID: <87o6du6hsl.fsf@igalia.com> (raw)
In-Reply-To: <CAOQ4uxipJkiiy8pURxRFdKYbruBM8wQxArd8uAiv2Dh=tPwNhA@mail.gmail.com>
On Thu, Sep 17 2026, Amir Goldstein wrote:
> On Wed, Sep 16, 2026 at 5:55 PM Luis Henriques <luis@igalia.com> wrote:
>>
>> This new file aims at documenting the caches that are used by FUSE. At
>> the moment only symlink, attributes, ACLs and readdir caches are described.
>>
>> Signed-off-by: Luis Henriques <luis@igalia.com>
>> ---
>> .../filesystems/fuse/fuse-caches.rst | 148 ++++++++++++++++++
>> Documentation/filesystems/fuse/index.rst | 1 +
>> 2 files changed, 149 insertions(+)
>> create mode 100644 Documentation/filesystems/fuse/fuse-caches.rst
>>
>> diff --git a/Documentation/filesystems/fuse/fuse-caches.rst b/Documentation/filesystems/fuse/fuse-caches.rst
>> new file mode 100644
>> index 000000000000..b133066429b1
>> --- /dev/null
>> +++ b/Documentation/filesystems/fuse/fuse-caches.rst
>> @@ -0,0 +1,148 @@
>> +.. SPDX-License-Identifier: GPL-2.0
>> +
>> +===========
>> +FUSE Caches
>> +===========
>> +
>> +Introduction
>> +============
>> +
>> +This document summarises the different types of caches used in FUSE. For each
>> +cache type, it documents the rules to insert data into it. It also documents the
>> +rules for validating and invalidating data in the cache.
>> +
>> +symlink caching
>> +===============
>> +
>> +Whenever there's a link resolution request for a FUSE filesystem, the VFS will
>> +call into ``fuse_get_link()``, the ``->get_link()`` inode operation. This
>> +function will then send a ``FUSE_READLINK`` request to the user-space FUSE
>> +server.
>> +
>> +The server can ask the kernel to cache all link resolutions by setting the
>> +``FUSE_CACHE_SYMLINKS`` flag during the ``FUSE_INIT`` negotiation. If this flag
>> +is set, when the VFS calls into the ``->get_link()`` operation, FUSE will
>> +immediately call ``__page_get_link()``. The first time this is done for a
>> +specific inode, it will result in sending the ``FUSE_READLINK`` request to
>> +user-space. But the result returned from this request will then be added into
>> +the page-cache. The next time this link needs to be resolved, it will use the
>> +link resolution already cached, and will only fallback to user-space if the
>> +folio isn't up-to-date.
>> +
>> +Attributes caching
>> +==================
>> +
>> +Inode attributes may be obtained from user-space by different FUSE operations.
>> +For example, ``FUSE_LOOKUP``, ``FUSE_GETATTR``, and also several other
>> +operations that create file system objects (e.g. ``FUSE_MKDIR``). These
>> +attributes obtained from user-space are cached by the kernel. They have,
>> +however, a timeout associated and once it expires, they are invalidated. The
>> +next time the attributes are needed, a request (``FUSE_GETATTR``) will be sent
>> +to the FUSE server.
>> +
>> +The ``FUSE_GETATTR`` request can be sent to user-space in three different
>> +scenarios:
>> +
>> +#. if the attributes for the inode aren't yet available in the kernel;
>> +#. if they are not valid any more (timed-out, or have been invalidated), or
>> +#. if there is an explicit request for forcing the request to be sent (for
>> + example, by using the ``AT_STATX_FORCE_SYNC`` flag in ``statx``).
>> +
>> +Regarding the attributes invalidation, they may happen in several occasions. For
>> +example, upon a user-space request for invalidation, through
>> +``FUSE_NOTIFY_INVAL_INODE``, ``FUSE_NOTIFY_INVAL_ENTRY``, or
>> +``FUSE_NOTIFY_DELETE`` requests.
>> +
>> +FUSE uses fine-grained invalidation masks rather than invalidating all
>> +attributes at once. The principle is that each operation only invalidates the
>> +specific attributes that the operation could have changed on the server. The
>> +masks used are:
>> +
>> +- ``STATX_ATIME`` - after reads and readlink, since the server may update access
>> + time
>> +- ``STATX_CTIME`` - after xattr changes (including ACL set/remove) and rename
>> +- ``STATX_BLOCKS`` - after a successful flush with writeback cache, since the
>> + server's block count may differ from the local one
>> +- ``FUSE_STATX_MODIFY`` (``STATX_MTIME | STATX_CTIME | STATX_BLOCKS``) - after
>> + writeback completion (without writeback cache), since the server may have
>> + updated modification metadata
>> +- ``FUSE_STATX_MODSIZE`` (``FUSE_STATX_MODIFY | STATX_SIZE``) - after writes,
>> + truncate-on-open, and fallocate, since the server's size and modification
>> + metadata may have changed
>> +- ``FUSE_STATX_MODDIR`` (``FUSE_STATX_MODSIZE | STATX_NLINK``) - after directory
>> + modifications (create, unlink, mkdir, rmdir, rename), since the server may
>> + have updated the directory's size, timestamps, and link count
>> +- ``STATX_BASIC_STATS`` - as a full invalidation, used for server-initiated
>> + invalidation (FUSE\ :sub:`NOTIFY`\ \_INVAL\ :sub:`INODE`), interrupted
>
> What is this odd subscript format and why? Please remove it.
Oops! I use pandoc to convert the text into rst, and looks like it's
misbehaving here. I'll investigate what went wrong and fix this. (And
next time I'll re-read the doc in rst.)
Thanks a lot for your feedback, I'll incorporate the suggestions below
into v5.
Cheers,
--
Luís
>> + setattr, and interrupted link
>> +
>> +The full set of invalidation points can be found by searching for
>> +``fuse_invalidate_attr_mask()`` in the FUSE source.
>> +
>> +ACL caching
>> +===========
>> +
>> +FUSE has allowed the usage of POSIX Access Control Lists (ACLs) for a long time,
>> +as they can be set and accessed simply as extended attributes. However, it was
>> +only with the introduction of the ``FUSE_POSIX_ACL`` flag that ACLs started to
>> +be fully supported. Without this flag being set during the ``FUSE_INIT``
>> +negotiation, ACLs can still be set, but the VFS won't use them for performing
>> +permission checks - that would be the user-space server's responsibility.
>> +
>> +Also, without setting ``FUSE_POSIX_ACL``, ACLs will not be cached by the kernel.
>
> This Also, feels out of place and unneeded for the document flow.
>
>> +In this case, new inodes ``i_acl`` and ``i_default_acl`` fields will be set to
>> +``ACL_DONT_CACHE``.
>> +
>> +On the other hand, if the ``FUSE_POSIX_ACL`` flag is set then, when an inode ACL
>
> This OTOH, feels out of place and unneeded for the document flow.
>
>> +is accessed, VFS will first check if it's already cached. If it is not, FUSE
>> +``->get_acl()`` operation (``fuse_get_acl()``) is called, which will eventually
>> +send a user-space request. Future accesses to this inode ACL will use the cached
>> +data.
>> +
>> +Setting an ACL in an inode will also result in sending a request to the FUSE
>> +server for setting it. But this operation won't immediately cache the ACL -- it
>> +will only be cached after it is accessed again and requested from user-space.
>> +
>> +On the other hand, ACLs will be removed from the cache in the following
>
> This OTOH, feels out of place and unneeded for the document flow.
> Which text is it referring to? Anyway, text seems better and clear without it.
>
>> +situations:
>> +
>> +- When setting an ACL in an inode (and the ``FUSE_POSIX_ACL`` flag is set),
>> + previously cached ACLs for this inode will be invalidated.
>> +- When invalidating an inode through the ``FUSE_NOTIFY_INVAL_INODE`` operation.
>> +- After setting an inode attribute (i.e. operation ``FUSE_SETATTR`` is sent to
>> + user-space), the user-space server may have also updated the ACLs. Thus, any
>> + cached ACLs for this inode are also invalidated.
>> +- Whenever attributes are refreshed from the server. For example, when while
>
> stray while - please remove
>
>> + revalidating a dentry (``->d_revalidate()``), or when updating a dentry during
>> + while processing a ``FUSE_READDIRPLUS``.
>
> stray while - please remove
>
>> +- In general, when there is the need to send a ``FUSE_STATX`` or
>> + ``FUSE_GETATTR`` to user-space (e.g. when attributes expired).
>> +
>> +readdir caching
>> +===============
>> +
>> +When opening a directory a ``FUSE_OPENDIR`` will be sent to the FUSE server, and
>> +server will be responsible for setting the open flags related with caching,
>> +namely ``FOPEN_KEEP_CACHE`` and ``FOPEN_CACHE_DIR``.
>> +
>> +If neither flags are set by the user-space FUSE server, then every ``readdir``
>> +will result in a ``FUSE_READDIR`` (or ``FUSE_READDIRPLUS``) request being sent.
>> +If ``FOPEN_CACHE_DIR`` is set by the server, then the result of a ``readdir``
>> +will be cached by the kernel and reused for the current open.
>
> I understand what you mean but it sounds confusing.
>
>> +``FOPEN_KEEP_CACHE`` is about keeping the cache on **this** open, not on some
>> +**next** open.
>
> Suggest:
>
> FOPEN_CACHE_DIR determines if readdir results of this open will be cached and if
> readdir cache will be used to return readdir results during the current open.
> If FOPEN_KEEP_CACHE is set, any readdir cache from previous opens is preserved
> when the directory is opened. Otherwise, the old readdir cache is
> invalidated on open.
>
> If you accept this phrasing and fix the style nits above, feel free to add
>
> Reviewed-by: Amir Goldstein <amir73il@gmail.com>
>
> Thanks,
> Amir.
next prev parent reply other threads:[~2026-09-18 9:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 15:56 [RFC PATCH v4 0/8] fuse: caches documentation and testing Luis Henriques
2026-09-16 15:56 ` [RFC PATCH v4 1/8] Documentation: fuse: add document on caches being used by FUSE Luis Henriques
2026-09-17 15:47 ` Amir Goldstein
2026-09-18 9:16 ` Luis Henriques [this message]
2026-09-16 15:56 ` [RFC PATCH v4 2/8] selftests/fuse: convert fusectl test to fuse3 Luis Henriques
2026-09-16 15:56 ` [RFC PATCH v4 3/8] selftests/fuse: check that fusectlfs is mounted Luis Henriques
2026-09-16 15:56 ` [RFC PATCH v4 4/8] selftests/fuse: factor-out test fixture setup/teardown Luis Henriques
2026-09-17 15:11 ` Amir Goldstein
2026-09-18 9:28 ` Luis Henriques
2026-09-16 15:56 ` [RFC PATCH v4 5/8] selftests/fuse: use dynamically allocated memory to store ACLs Luis Henriques
2026-09-16 15:56 ` [RFC PATCH v4 6/8] selftests/fuse: add some extra ACL caching tests Luis Henriques
2026-09-17 15:14 ` Amir Goldstein
2026-09-16 15:56 ` [RFC PATCH v4 7/8] selftests/fuse: add fuse symlink caching test Luis Henriques
2026-09-17 15:18 ` Amir Goldstein
2026-09-16 15:56 ` [RFC PATCH v4 8/8] selftests/fuse: add fuse readdir " Luis Henriques
2026-09-17 15:21 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o6du6hsl.fsf@igalia.com \
--to=luis@igalia.com \
--cc=amir73il@gmail.com \
--cc=corbet@lwn.net \
--cc=fuse-devel@lists.linux.dev \
--cc=kernel-dev@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=me@black-desk.cn \
--cc=mharvey@jumptrading.com \
--cc=miklos@szeredi.hu \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®