* [PATCH v1] ALSA: hda/tas2781: Add tas2781_hda::catlog_id init
@ 2026-01-26 3:18 Shenghao Ding
2026-01-26 8:41 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Shenghao Ding @ 2026-01-26 3:18 UTC (permalink / raw)
To: tiwai
Cc: broonie, andriy.shevchenko, linux-kernel, baojun.xu, Baojun.Xu,
13564923607, 13916275206, Shenghao Ding
The default of tas2781_hda::catlog_id is DELL, which cause calibration
data is not loaded in HP SPI-basded Laptop, because only HP laptop
supports SPI-based TAS2781.
Fixes: 9fa6a693ad8d ("ALSA: hda/tas2781: Remove tas2781_spi_fwlib.c and leverage SND_SOC_TAS2781_FMWLIB")
Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>
---
sound/hda/codecs/side-codecs/tas2781_hda_spi.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sound/hda/codecs/side-codecs/tas2781_hda_spi.c b/sound/hda/codecs/side-codecs/tas2781_hda_spi.c
index 5454b7ac22c6..0c9b57b6ff55 100644
--- a/sound/hda/codecs/side-codecs/tas2781_hda_spi.c
+++ b/sound/hda/codecs/side-codecs/tas2781_hda_spi.c
@@ -727,6 +727,9 @@ static int tas2781_hda_bind(struct device *dev, struct device *master,
if (!ret)
comp->playback_hook = tas2781_hda_playback_hook;
+ /* Only HP Laptop support SPI-based TAS2781 */
+ tas_hda->catlog_id = HP;
+
return ret;
}
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v1] ALSA: hda/tas2781: Add tas2781_hda::catlog_id init
2026-01-26 3:18 [PATCH v1] ALSA: hda/tas2781: Add tas2781_hda::catlog_id init Shenghao Ding
@ 2026-01-26 8:41 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2026-01-26 8:41 UTC (permalink / raw)
To: Shenghao Ding
Cc: tiwai, broonie, andriy.shevchenko, linux-kernel, baojun.xu,
Baojun.Xu, 13564923607, 13916275206
On Mon, 26 Jan 2026 04:18:16 +0100,
Shenghao Ding wrote:
>
> The default of tas2781_hda::catlog_id is DELL, which cause calibration
> data is not loaded in HP SPI-basded Laptop, because only HP laptop
> supports SPI-based TAS2781.
>
> Fixes: 9fa6a693ad8d ("ALSA: hda/tas2781: Remove tas2781_spi_fwlib.c and leverage SND_SOC_TAS2781_FMWLIB")
>
> Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>
Applied now. Thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-01-26 8:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-01-26 3:18 [PATCH v1] ALSA: hda/tas2781: Add tas2781_hda::catlog_id init Shenghao Ding
2026-01-26 8:41 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®