From: "Bjørn Mork" <bjorn@mork.no>
To: Jay Vosburgh <jay.vosburgh@canonical.com>
Cc: Michael J Dilmore <michael.j.dilmore@gmail.com>,
David Miller <davem@davemloft.net>,
vfalico@gmail.com, andy@greyhouse.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, joe@perches.com
Subject: Re: [PATCH] Convert BUG_ON to WARN_ON in bond_options.c
Date: Thu, 22 Jun 2017 10:14:31 +0200 [thread overview]
Message-ID: <87o9tg1lso.fsf@miraculix.mork.no> (raw)
In-Reply-To: <24691.1498084768@famine> (Jay Vosburgh's message of "Wed, 21 Jun 2017 15:39:28 -0700")
Jay Vosburgh <jay.vosburgh@canonical.com> writes:
> Michael J Dilmore <michael.j.dilmore@gmail.com> wrote:
>
>>if (WARN_ON(!new_active_slave) {
>> netdev_dbg("Can't add new active slave - pointer null");
>> return ERROR_CODE
>>}
>
> In general, yes, but in this case, the condition should be
> impossible to hit, so BUG_ON seems appropriate.
If it really is impossible then you should simply remove the test. No
need to test for the impossible, is there?
Bjørn
next prev parent reply other threads:[~2017-06-22 8:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 18:02 Michael J Dilmore
2017-06-21 18:33 ` Jay Vosburgh
2017-06-21 21:35 ` Michael D
2017-06-21 21:36 ` David Miller
2017-06-21 21:41 ` Michael D
2017-06-21 21:56 ` David Miller
2017-06-21 22:27 ` Michael J Dilmore
2017-06-21 22:39 ` Jay Vosburgh
2017-06-21 23:04 ` Michael J Dilmore
2017-06-22 8:04 ` Michal Kubecek
2017-06-22 8:14 ` Bjørn Mork [this message]
2017-06-21 22:31 ` Jay Vosburgh
2017-06-21 21:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9tg1lso.fsf@miraculix.mork.no \
--to=bjorn@mork.no \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=jay.vosburgh@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.j.dilmore@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®