Re: [PATCH 2/2] fat (exportfs): reconnect file handles to evicted inodes/dentries

[OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>]

"Steven J. Magnani" <steve@digidescorp.com> writes:

> On Mon, 2012-07-09 at 22:43 +0900, OGAWA Hirofumi wrote: 
>> "Steven J. Magnani" <steve@digidescorp.com> writes:
>> 
>> >> We need the key, possible key is - if it is only directory, FAT may be
>> >> able to use i_start as additional search key.
>> >
>> > Interesting idea. I think this, and reformulating the FAT NFS file
>> > handle to include the parent's i_ino, will greatly simplify (and speed
>> > up) the code.
>> 
>> Does it work even if the inode was rename()'ed?
>
> AFAICT. I don't see why it wouldn't; on a rename, the inode's i_pos
> changes but its i_ino stays the same, right?

If the inode is not on cache anymore, is there the possibility that
selects the wrong parent? IIRC, NFS Server can be rebooted at any time
while the client using the same file handle.

> Do you have any objection to making the use of a directory logstart
> cache a mount option that defaults to off? It seems a shame to penalize
> everyone - particularly embedded systems - with the overhead of such a
> cache when FAT-backed-NFS seems to be such a small percentage of use
> cases.

I'm not sure what did it mean. It means to remove i_logstart from NFS
file handle?
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>