From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: "Steven J. Magnani" <steve@digidescorp.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] fat (exportfs): reconnect file handles to evicted inodes/dentries
Date: Tue, 10 Jul 2012 07:17:09 +0900 [thread overview]
Message-ID: <87zk78mvfe.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <1341871431.1944.4.camel@iscandar> (Steven J. Magnani's message of "Mon, 09 Jul 2012 17:03:51 -0500")
"Steven J. Magnani" <steve@digidescorp.com> writes:
>> Hm, not really, if the file handle is including parent ino. ext2 will
>> get the latest parent ino, because it checks parent of inode of file
>> handle.
>
> Can you point me to the code for this? The code I see looks pretty
> congruent to what I think the FAT code would be.
>
>> But if the file handle is including parent ino and we believe it is
>> parent, I think NFS server can be return the old parent. The difference
>> is the result of ->get_parent().
>
> I'm a little confused about which function we're discussing here.
> fat_get_parent() isn't called with a file handle. fat_fh_to_parent() is,
> but it is only called by exportfs_decode_fh() and I am reasonably sure
> that that function is handling the case you're concerned about.
Oh, you are right. I should discuss about it based on the new patch, and
only if there is new usage of file handle (e.g. parent->i_no).
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
prev parent reply other threads:[~2012-07-09 22:17 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 19:09 [PATCH 0/2] fat (exportfs): fix NFS file handle decode Steven J. Magnani
2012-07-03 19:09 ` [PATCH 1/2] fat (exportfs): drop ineffective get_parent code Steven J. Magnani
2012-07-04 10:30 ` OGAWA Hirofumi
2012-07-03 19:09 ` [PATCH 2/2] fat (exportfs): reconnect file handles to evicted inodes/dentries Steven J. Magnani
2012-07-04 11:07 ` OGAWA Hirofumi
2012-07-04 18:03 ` Steve Magnani
2012-07-05 3:59 ` OGAWA Hirofumi
2012-07-05 20:03 ` Steven J. Magnani
2012-07-06 20:33 ` Steven J. Magnani
2012-07-06 21:07 ` OGAWA Hirofumi
2012-07-07 1:16 ` Steven J. Magnani
2012-07-07 6:03 ` OGAWA Hirofumi
2012-07-07 16:41 ` Steven J. Magnani
2012-07-07 17:00 ` OGAWA Hirofumi
2012-07-09 12:03 ` Steven J. Magnani
2012-07-09 13:43 ` OGAWA Hirofumi
2012-07-09 14:47 ` Steven J. Magnani
2012-07-09 16:10 ` OGAWA Hirofumi
2012-07-09 16:27 ` Steven J. Magnani
2012-07-09 17:09 ` Steven J. Magnani
2012-07-09 17:23 ` Steven J. Magnani
2012-07-09 19:10 ` OGAWA Hirofumi
2012-07-09 20:26 ` Steven J. Magnani
2012-07-09 21:34 ` OGAWA Hirofumi
2012-07-09 22:03 ` Steven J. Magnani
2012-07-09 22:17 ` OGAWA Hirofumi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zk78mvfe.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=steve@digidescorp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome