* [PATCH] selftests: ALSA: pcmtest: Compare all captured bytes in ni_capture
@ 2026-10-21 11:25 HyeongJun An
2026-10-21 13:05 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: HyeongJun An @ 2026-10-21 11:25 UTC (permalink / raw)
To: Takashi Iwai
Cc: Ivan Orlov, Mark Brown, Jaroslav Kysela, Shuah Khan, linux-sound,
linux-kselftest, linux-kernel, HyeongJun An
The ni_capture test reads rate * time frames into each channel buffer
and then compares rate * time bytes. A frame is sample_size bytes per
channel, so with S16_LE only the first half of each channel is checked.
If the second half is wrong the test still passes.
Compare rate * time * sample_size bytes per channel.
Fixes: 10b98a4db11a ("selftests: ALSA: Add test for the 'pcmtest' driver")
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: HyeongJun An <sammiee5311@gmail.com>
---
tools/testing/selftests/alsa/test-pcmtest-driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/alsa/test-pcmtest-driver.c b/tools/testing/selftests/alsa/test-pcmtest-driver.c
index e025a7bac26b..18ee72d5d4c9 100644
--- a/tools/testing/selftests/alsa/test-pcmtest-driver.c
+++ b/tools/testing/selftests/alsa/test-pcmtest-driver.c
@@ -265,7 +265,7 @@ TEST_F(pcmtest, ni_capture) {
snd_pcm_close(handle);
for (i = 0; i < CH_NUM; i++) {
- for (j = 0; j < params.rate * params.time; j++)
+ for (j = 0; j < params.rate * params.time * params.sample_size; j++)
ASSERT_EQ(chan_samples[i][j], patterns[i].buf[j % patterns[i].len]);
free(chan_samples[i]);
}
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] selftests: ALSA: pcmtest: Compare all captured bytes in ni_capture
2026-10-21 11:25 [PATCH] selftests: ALSA: pcmtest: Compare all captured bytes in ni_capture HyeongJun An
@ 2026-10-21 13:05 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2026-10-21 13:05 UTC (permalink / raw)
To: HyeongJun An
Cc: Takashi Iwai, Ivan Orlov, Mark Brown, Jaroslav Kysela,
Shuah Khan, linux-sound, linux-kselftest, linux-kernel
On Wed, 21 Oct 2026 13:25:54 +0200,
HyeongJun An wrote:
>
> The ni_capture test reads rate * time frames into each channel buffer
> and then compares rate * time bytes. A frame is sample_size bytes per
> channel, so with S16_LE only the first half of each channel is checked.
> If the second half is wrong the test still passes.
>
> Compare rate * time * sample_size bytes per channel.
>
> Fixes: 10b98a4db11a ("selftests: ALSA: Add test for the 'pcmtest' driver")
> Assisted-by: Claude:claude-opus-5-5
> Signed-off-by: HyeongJun An <sammiee5311@gmail.com>
Applied now. Thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-21 13:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-21 11:25 [PATCH] selftests: ALSA: pcmtest: Compare all captured bytes in ni_capture HyeongJun An
2026-10-21 13:05 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®