[PATCH] ASoC: rsnd: src: Add missing scu_supply clock to suspend/resume

[PATCH] ASoC: rsnd: src: Add missing scu_supply clock to suspend/resume

[John Madieu]

scu_supply is enabled alongside scu and scu_x2 during normal SRC
operation, but rsnd_src_suspend() and rsnd_src_resume() only disable
and re-enable scu and scu_x2. The supply clock is left enabled across
a system suspend and its prepare/enable refcount becomes unbalanced
after a suspend/resume cycle.

Disable scu_supply in rsnd_src_suspend() and re-enable it in
rsnd_src_resume() so the SRC clocks are managed consistently across
system PM transitions.

Fixes: ef19ecf042b4 ("ASoC: rsnd: Add system suspend/resume support")
Signed-off-by: John Madieu <john.madieu.xa@bp.renesas.com>
---
 sound/soc/renesas/rcar/src.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/soc/renesas/rcar/src.c b/sound/soc/renesas/rcar/src.c
index ac806bdc96d9..2cdb39e898af 100644
--- a/sound/soc/renesas/rcar/src.c
+++ b/sound/soc/renesas/rcar/src.c
@@ -850,6 +850,7 @@ void rsnd_src_suspend(struct rsnd_priv *priv)

 	clk_disable_unprepare(src_ctrl->scu_x2);
 	clk_disable_unprepare(src_ctrl->scu);
+	clk_disable_unprepare(src_ctrl->scu_supply);
 }

 void rsnd_src_resume(struct rsnd_priv *priv)
@@ -861,6 +862,7 @@ void rsnd_src_resume(struct rsnd_priv *priv)
 	if (!src_ctrl)
 		return;

+	clk_prepare_enable(src_ctrl->scu_supply);
 	clk_prepare_enable(src_ctrl->scu);
 	clk_prepare_enable(src_ctrl->scu_x2);

--
2.25.1

Re: [PATCH] ASoC: rsnd: src: Add missing scu_supply clock to suspend/resume

[Kuninori Morimoto]

Hi John

> scu_supply is enabled alongside scu and scu_x2 during normal SRC
> operation, but rsnd_src_suspend() and rsnd_src_resume() only disable
> and re-enable scu and scu_x2. The supply clock is left enabled across
> a system suspend and its prepare/enable refcount becomes unbalanced
> after a suspend/resume cycle.
> 
> Disable scu_supply in rsnd_src_suspend() and re-enable it in
> rsnd_src_resume() so the SRC clocks are managed consistently across
> system PM transitions.
> 
> Fixes: ef19ecf042b4 ("ASoC: rsnd: Add system suspend/resume support")
> Signed-off-by: John Madieu <john.madieu.xa@bp.renesas.com>
> ---

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>


Thank you for your help !!

Best regards
---
Kuninori Morimoto

Re: [PATCH] ASoC: rsnd: src: Add missing scu_supply clock to suspend/resume

[Mark Brown]

On Tue, 30 Jun 2026 17:53:29 +0000, John Madieu wrote:
> ASoC: rsnd: src: Add missing scu_supply clock to suspend/resume

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.2

Thanks!

[1/1] ASoC: rsnd: src: Add missing scu_supply clock to suspend/resume
      https://git.kernel.org/broonie/sound/c/83245e7a436c

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark