mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Stefan Binding <sbinding@opensource.cirrus.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	<alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
	<patches@opensource.cirrus.com>
Subject: Re: [PATCH v2 3/3] ALSA: hda/realtek: Delete cs35l41 component master during free
Date: Mon, 05 Jun 2023 18:00:58 +0200	[thread overview]
Message-ID: <87pm69hpad.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230605152855.448115-4-sbinding@opensource.cirrus.com>

On Mon, 05 Jun 2023 17:28:55 +0200,
Stefan Binding wrote:
> 
> This ensures that the driver is properly cleaned up when freed.
> 
> Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com>
> ---
>  sound/pci/hda/patch_realtek.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 7b5f194513c7b..e3774903918fe 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -6757,6 +6757,8 @@ static void cs35l41_generic_fixup(struct hda_codec *cdc, int action, const char
>  		else
>  			spec->gen.pcm_playback_hook = comp_generic_playback_hook;
>  		break;
> +	case HDA_FIXUP_ACT_FREE:
> +		component_master_del(dev, &comp_master_ops);
>  	}

Don't forget to add break here.


thanks,

Takashi

      reply	other threads:[~2023-06-05 16:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-05 15:28 [PATCH v2 0/3] Fixes and cleanup for CS35L41 HDA Stefan Binding
2023-06-05 15:28 ` [PATCH v2 1/3] ALSA: hda: cs35l41: Clean up Firmware Load Controls Stefan Binding
2023-06-05 15:28 ` [PATCH v2 2/3] ALSA: hda: cs35l41: Fix endian conversions Stefan Binding
2023-06-05 15:28 ` [PATCH v2 3/3] ALSA: hda/realtek: Delete cs35l41 component master during free Stefan Binding
2023-06-05 16:00   ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pm69hpad.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=perex@perex.cz \
    --cc=sbinding@opensource.cirrus.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®