From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: Alexey Budankov <alexey.budankov@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Andi Kleen <ak@linux.intel.com>, Kan Liang <kan.liang@intel.com>,
Dmitri Prokhorov <Dmitry.Prohorov@intel.com>,
Valery Cherepennikov <valery.cherepennikov@intel.com>,
Mark Rutland <mark.rutland@arm.com>,
David Carrillo-Cisneros <davidcc@google.com>,
Stephane Eranian <eranian@google.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 4/4]: perf/core: complete replace of lists by rb trees for pinned and flexible groups at perf_event_context
Date: Tue, 18 Jul 2017 18:23:34 +0300 [thread overview]
Message-ID: <87pocxvkeh.fsf@ashishki-desk.ger.corp.intel.com> (raw)
In-Reply-To: <dcf170c8-5096-4c4c-24a2-58e37c40d2d7@linux.intel.com>
Alexey Budankov <alexey.budankov@linux.intel.com> writes:
>> You probably also want to explain this change, for example change the
>> @group_list description, saying that something else links into it now.
>>
>
> The whole patch as a single commit, attached to patch v5 4/4, may provide
> the complete view of suggested changes.
No, each patch has to be readable on its own. If one has to jump between
patches to figure out what's going on, it's already discouraging. The
point of submitting a patch, on the other hand, is to encourage the
reviewers to read on.
Regards,
--
Alex
next prev parent reply other threads:[~2017-07-18 15:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 13:03 Alexey Budankov
2017-07-18 8:40 ` Alexey Budankov
2017-07-18 11:33 ` Alexander Shishkin
2017-07-18 11:35 ` Alexander Shishkin
2017-07-18 13:38 ` Alexey Budankov
2017-07-18 14:01 ` Alexander Shishkin
2017-07-18 14:30 ` Alexey Budankov
2017-07-18 15:08 ` Alexander Shishkin
2017-07-18 15:25 ` Alexey Budankov
2017-07-18 16:55 ` Alexander Shishkin
2017-07-18 19:52 ` Alexey Budankov
2017-07-19 5:48 ` Alexander Shishkin
2017-07-19 7:53 ` Alexey Budankov
2017-07-18 12:40 ` Alexander Shishkin
2017-07-18 13:38 ` Alexey Budankov
2017-07-18 15:23 ` Alexander Shishkin [this message]
2017-07-18 15:32 ` Alexey Budankov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pocxvkeh.fsf@ashishki-desk.ger.corp.intel.com \
--to=alexander.shishkin@linux.intel.com \
--cc=Dmitry.Prohorov@intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexey.budankov@linux.intel.com \
--cc=davidcc@google.com \
--cc=eranian@google.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=valery.cherepennikov@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®