From: Michael Ellerman <mpe@ellerman.id.au>
To: "Emilio López" <emilio.lopez@collabora.co.uk>
Cc: shuah@kernel.org, devel@driverdev.osuosl.org,
gustavo.padovan@collabora.co.uk, riandrews@android.com,
daniel.vetter@ffwll.ch, John.C.Harrison@Intel.com,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
ghackmann@google.com, robdclark@gmail.com,
linux-kselftest@vger.kernel.org,
maarten.lankhorst@linux.intel.com, daniels@collabora.com,
arve@android.com, emil.l.velikov@gmail.com
Subject: Re: [PATCH 1/7] selftest: sync: basic tests for sw_sync framework
Date: Tue, 27 Sep 2016 14:23:25 +1000 [thread overview]
Message-ID: <87ponq6kea.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <56f420ed-e985-2433-31fd-50515d8bcd1c@collabora.co.uk>
Emilio López <emilio.lopez@collabora.co.uk> writes:
> El 22/09/16 a las 06:43, Michael Ellerman escribió:
>> Emilio López <emilio.lopez@collabora.co.uk> writes:
>>
>> Please don't include the *kernel* headers, they're really not meant to
>> be used in userspace programs :)
>>
>>> +CFLAGS += -I../../../../usr/include/
>>
>> That is the correct place to get them from. They'll have been put there
>> by 'make headers_install'.
>
> My inspiration here has been tools/testing/selftests/memfd/Makefile,
> which does it this way. If I only include the ones on usr then it
> doesn't build, as there's no sync_file.h available, even after running
> make headers_install. How am I supposed to use the ioctls from there?
It looks like it's missing from include/uapi/linux/Kbuild, you need to
add it to the list of exported headers:
diff --git a/include/uapi/linux/Kbuild b/include/uapi/linux/Kbuild
index dd604395606b..40411b4ff012 100644
--- a/include/uapi/linux/Kbuild
+++ b/include/uapi/linux/Kbuild
@@ -397,6 +397,7 @@ header-y += stddef.h
header-y += string.h
header-y += suspend_ioctls.h
header-y += swab.h
+header-y += sync_file.h
header-y += synclink.h
header-y += sysctl.h
header-y += sysinfo.h
cheers
next prev parent reply other threads:[~2016-09-27 4:23 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 21:11 [PATCH 0/7] Tests for sync infrastructure Emilio López
2016-09-21 21:11 ` [PATCH 1/7] selftest: sync: basic tests for sw_sync framework Emilio López
2016-09-22 9:43 ` Michael Ellerman
2016-09-22 14:23 ` Emilio López
2016-09-27 4:23 ` Michael Ellerman [this message]
2016-09-27 14:51 ` Emilio López
2016-10-05 1:00 ` Michael Ellerman
2016-09-21 21:12 ` [PATCH 2/7] selftest: sync: fence " Emilio López
2016-09-21 21:12 ` [PATCH 3/7] selftest: sync: merge " Emilio López
2016-09-21 21:12 ` [PATCH 4/7] selftest: sync: wait " Emilio López
2016-09-21 21:12 ` [PATCH 5/7] selftest: sync: stress test for parallelism Emilio López
2016-09-21 21:12 ` [PATCH 6/7] selftest: sync: stress consumer/producer test Emilio López
2016-09-21 21:12 ` [PATCH 7/7] selftest: sync: stress test for merges Emilio López
2016-10-19 12:49 ` [PATCH v2 0/7] Tests for sync infrastructure Emilio López
2016-10-19 12:49 ` [PATCH v2 1/7] selftest: sync: basic tests for sw_sync framework Emilio López
2016-11-01 16:18 ` Gustavo Padovan
2016-12-13 16:46 ` Shuah Khan
2016-10-19 12:49 ` [PATCH v2 2/7] selftest: sync: fence " Emilio López
2016-10-19 12:49 ` [PATCH v2 3/7] selftest: sync: merge " Emilio López
2016-10-19 12:49 ` [PATCH v2 4/7] selftest: sync: wait " Emilio López
2016-10-19 12:49 ` [PATCH v2 5/7] selftest: sync: stress test for parallelism Emilio López
2016-10-19 12:49 ` [PATCH v2 6/7] selftest: sync: stress consumer/producer test Emilio López
2016-10-19 12:49 ` [PATCH v2 7/7] selftest: sync: stress test for merges Emilio López
2016-12-02 1:17 ` [PATCH v2 0/7] Tests for sync infrastructure Shuah Khan
2016-12-02 14:08 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ponq6kea.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=John.C.Harrison@Intel.com \
--cc=arve@android.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniels@collabora.com \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=emilio.lopez@collabora.co.uk \
--cc=ghackmann@google.com \
--cc=gustavo.padovan@collabora.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=riandrews@android.com \
--cc=robdclark@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®