mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	linux-kernel@vger.kernel.org, David Ahern <dsahern@gmail.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Jiri Olsa <jolsa@redhat.com>, Mike Galbraith <efault@gmx.de>,
	Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Stephane Eranian <eranian@google.com>,
	Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH V9 08/14] perf tools: move struct ip_event
Date: Wed, 07 Aug 2013 17:22:19 +0900	[thread overview]
Message-ID: <87pptpykp0.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <1375719994-26482-9-git-send-email-adrian.hunter@intel.com> (Adrian Hunter's message of "Mon, 5 Aug 2013 19:26:28 +0300")

On Mon,  5 Aug 2013 19:26:28 +0300, Adrian Hunter wrote:
> struct ip_event assumes fixed positions for ip, pid
> and tid.  That is no longer true with the addition of
> PERF_SAMPLE_IDENTIFIER.
>
> struct ip_event is no longer used except by hists_link.c.
> Move it there.

I think you can just get rid of ip_event and fill sample->ip/pid from
fake_common_samples directly.  The reason of using ip_event was because
it's used in perf_event__preprocess_sample() but you've removed it. :)

Thanks,
Namhyung

  reply	other threads:[~2013-08-07  8:22 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-05 16:26 [PATCH V9 00/14] perf tools: some fixes and tweaks Adrian Hunter
2013-08-05 16:26 ` [PATCH V9 01/14] perf tools: add debug prints Adrian Hunter
2013-08-07  6:44   ` Namhyung Kim
2013-08-07  8:13     ` Adrian Hunter
2013-08-07  8:50       ` Namhyung Kim
2013-08-05 16:26 ` [PATCH V9 02/14] perf tools: allow non-matching sample types Adrian Hunter
2013-08-05 16:26 ` [PATCH V9 03/14] perf tools: add pid to struct thread Adrian Hunter
2013-08-05 16:26 ` [PATCH V9 04/14] perf tools: change machine__findnew_thread() to set thread pid Adrian Hunter
2013-08-07  7:51   ` Namhyung Kim
2013-08-07  8:34     ` Adrian Hunter
2013-08-07  8:40       ` Namhyung Kim
2013-08-05 16:26 ` [PATCH V9 05/14] perf tools: tidy up sample parsing overflow checking Adrian Hunter
2013-08-07  8:09   ` Namhyung Kim
2013-08-07  8:19     ` Adrian Hunter
2013-08-07  8:54       ` Namhyung Kim
2013-08-07 11:45         ` Adrian Hunter
2013-08-05 16:26 ` [PATCH V9 06/14] perf tools: remove unnecessary callchain validation Adrian Hunter
2013-08-05 16:26 ` [PATCH V9 07/14] perf tools: remove references to struct ip_event Adrian Hunter
2013-08-05 16:26 ` [PATCH V9 08/14] perf tools: move " Adrian Hunter
2013-08-07  8:22   ` Namhyung Kim [this message]
2013-08-05 16:26 ` [PATCH V9 09/14] perf: make events stream always parsable Adrian Hunter
2013-08-12  8:52   ` Peter Zijlstra
2013-08-05 16:26 ` [PATCH V9 10/14] perf tools: move perf_evlist__config() to a new source file Adrian Hunter
2013-08-05 16:26 ` [PATCH V9 11/14] perf tools: add support for PERF_SAMPLE_IDENTFIER Adrian Hunter
2013-08-05 16:26 ` [PATCH V9 12/14] perf tools: expand perf_event__synthesize_sample() Adrian Hunter
2013-08-05 16:26 ` [PATCH V9 13/14] perf tools: add a function to calculate sample event size Adrian Hunter
2013-08-05 16:26 ` [PATCH V9 14/14] perf tools: add a sample parsing test Adrian Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pptpykp0.fsf@sejong.aot.lge.com \
    --to=namhyung@kernel.org \
    --cc=acme@ghostprotocols.net \
    --cc=adrian.hunter@intel.com \
    --cc=dsahern@gmail.com \
    --cc=efault@gmx.de \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome