Re: [2.6.26 patch] fat_valid_media() isn't for userspace

[OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=iso-2022-jp-2, Size: 2025 bytes --]

Adrian Bunk <bunk@kernel.org> writes:

> This function isn't part of the kernel<->userspace API and therefore 
> shouldn't have been added at this place.
>
> I'd suggest the patch below instead.

Yes. This is new one, so it shouldn't have any users of that.
Looks more better. Thanks.

Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

> Commit 73f20e58b1d586e9f6d3ddc3aad872829aca7743
> (FAT_VALID_MEDIA(): remove pointless test)
> wrongly added the new fat_valid_media() function
> to the userspace-visible part of include/linux/msdos_fs.h
>
> Move it to the part of include/linux/msdos_fs.h that is not exported to 
> userspace.
>
> Reported-by: Onur K^[$(D+d+.+d^[(Bk <onur@pardus.org.tr>
> Reported-by: S.^[$(D*.^[(Ba^[$(D+;^[(Blar Onur <caglar@pardus.org.tr>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> ---
>
>  include/linux/msdos_fs.h |   12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> 4a56896ef4ef839cdc9d59fd7118c5051231c61e diff --git a/include/linux/msdos_fs.h b/include/linux/msdos_fs.h
> index b03b274..81cd36b 100644
> --- a/include/linux/msdos_fs.h
> +++ b/include/linux/msdos_fs.h
> @@ -57,12 +57,6 @@
>  #define MSDOS_DOT	".          "	/* ".", padded to MSDOS_NAME chars */
>  #define MSDOS_DOTDOT	"..         "	/* "..", padded to MSDOS_NAME chars */
>  
> -/* media of boot sector */
> -static inline int fat_valid_media(u8 media)
> -{
> -	return 0xf8 <= media || media == 0xf0;
> -}
> -
>  #define FAT_FIRST_ENT(s, x)	((MSDOS_SB(s)->fat_bits == 32 ? 0x0FFFFF00 : \
>  	MSDOS_SB(s)->fat_bits == 16 ? 0xFF00 : 0xF00) | (x))
>  
> @@ -334,6 +328,12 @@ static inline void fatwchar_to16(__u8 *dst, const wchar_t *src, size_t len)
>  #endif
>  }
>  
> +/* media of boot sector */
> +static inline int fat_valid_media(u8 media)
> +{
> +	return 0xf8 <= media || media == 0xf0;
> +}
> +
>  /* fat/cache.c */
>  extern void fat_cache_inval_inode(struct inode *inode);
>  extern int fat_get_cluster(struct inode *inode, int cluster,
>

-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>