From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: caglar@pardus.org.tr
Cc: linux-kernel@vger.kernel.org,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"Frank Seidel" <fseidel@suse.de>,
"Onur Küçük" <onur@pardus.org.tr>
Subject: Re: [PATCH] include/linux/msdos_fs.h: Cleanup include/linux/msdos_fs.h for userspace.
Date: Mon, 09 Jun 2008 03:36:26 +0900 [thread overview]
Message-ID: <87wskzn591.fsf@duaron.myhome.or.jp> (raw)
In-Reply-To: <200806082116.50355.caglar@pardus.org.tr> (=?iso-2022-jp-2?B?IlMuGyQoRCouGyhCYRskKEQrOxsoQmxhcg==?= Onur"'s message of "Sun, 8 Jun 2008 21:16:48 +0300")
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=iso-2022-jp-2, Size: 1606 bytes --]
"S.^[$(D*.^[(Ba^[$(D+;^[(Blar Onur" <caglar@pardus.org.tr> writes:
> include/linux/msdos_fs.h header should use __u## rather than u## types else any userspace code (like syslinux) includes that header fails to compile like following;
>
> [...]
> gcc -Wp,-MT,bootsect_bin.o,-MMD,.bootsect_bin.o.d -W -Wall -D_FILE_OFFSET_BITS=64 -g -Os -I. -I.. -I../libinstaller -c -o bootsect_bin.o ../bootsect_bin.c
> gcc -Wp,-MT,ldlinux_bin.o,-MMD,.ldlinux_bin.o.d -W -Wall -D_FILE_OFFSET_BITS=64 -g -Os -I. -I.. -I../libinstaller -c -o ldlinux_bin.o ../ldlinux_bin.c
> In file included from syslinux.c:52:
> /usr/include/linux/msdos_fs.h:61: error: expected ')' before 'media'
> [...]
>
> Noticed by Onur K^[$(D+d+.+d^[(Bk <onur@pardus.org.tr>
>
> Cc: Frank Seidel <fseidel@suse.de>
> CC: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
> CC: Onur K^[$(D+d+.+d^[(Bk <onur@pardus.org.tr>
>
> Signed-off-by: S.^[$(D*.^[(Ba^[$(D+;^[(Blar Onur <caglar@pardus.org.tr>
Looks good to me. Thanks.
Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
> include/linux/msdos_fs.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/msdos_fs.h b/include/linux/msdos_fs.h
> index b03b274..3825b1c 100644
> --- a/include/linux/msdos_fs.h
> +++ b/include/linux/msdos_fs.h
> @@ -58,7 +58,7 @@
> #define MSDOS_DOTDOT ".. " /* "..", padded to MSDOS_NAME chars */
>
> /* media of boot sector */
> -static inline int fat_valid_media(u8 media)
> +static inline int fat_valid_media(__u8 media)
> {
> return 0xf8 <= media || media == 0xf0;
> }
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2008-06-08 18:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-08 18:16 S.Çağlar Onur
2008-06-08 18:36 ` OGAWA Hirofumi [this message]
2008-06-08 18:43 ` [2.6.26 patch] fat_valid_media() isn't " Adrian Bunk
2008-06-08 18:55 ` OGAWA Hirofumi
2008-06-09 1:14 ` H. Peter Anvin
2008-06-09 4:12 ` OGAWA Hirofumi
2008-06-09 4:41 ` H. Peter Anvin
2008-06-09 8:05 ` Adrian Bunk
2008-06-09 22:26 ` [2.6 patch] fat/dir.c: switch to struct __fat_fs_dirent Adrian Bunk
2008-06-09 23:12 ` OGAWA Hirofumi
2008-06-09 22:27 ` [2.6 patch] remove the in-kernel struct dirent{,64} Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wskzn591.fsf@duaron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=caglar@pardus.org.tr \
--cc=fseidel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=onur@pardus.org.tr \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®