mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Mark Brown <broonie@kernel.org>
Cc: "Nuno Sá" <nuno.sa@analog.com>, "Fei Xie" <fei.xie@horizon.auto>,
	"Richard Weinberger" <richard@nod.at>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Parshuram Thombare" <pthombar@cadence.com>,
	linux-spi@vger.kernel.org, linux-mtd@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 2/4] spi: cadence-xspi: add ACMD support for SPI NAND
Date: Fri, 25 Sep 2026 14:59:15 +0200	[thread overview]
Message-ID: <87qzihjxlo.fsf@bootlin.com> (raw)
In-Reply-To: <85dc596e-4378-4d23-b48e-80053cb5166d@sirena.org.uk> (Mark Brown's message of "Fri, 25 Sep 2026 12:59:49 +0100")

On 25/09/2026 at 12:59:49 +01, Mark Brown <broonie@kernel.org> wrote:

> On Fri, Sep 25, 2026 at 12:23:21PM +0200, Miquel Raynal wrote:
>
>> > As for PROGRAM and ERASE commands I really did not saw any added
>> > value.
>
>> Yes, most of the time is spent in the wait_ready, which is not getting
>> faster with hardware automation.
>
> It might potentially help a heavily loaded system if you can do fewer
> waits, the rest of the tasks running on the system will have more time
> if we're doing fewer waits for interrupts.  Not sure it'd be enough to
> write home about though.

Definitely, but this is already possible, one may implement
ctlr->mem_ops->poll_status. This way the core can leverage the hardware
to perform the polling. It is not directly visible on benchmarks,
because it won't reduce much the wait time, but the system load will
decrease.

Thanks,
Miquèl

  reply	other threads:[~2026-09-25 12:59 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-21  9:36 [RFC PATCH 0/4] spi: cadence-xspi: add ACMD PIO support for NAND and NOR Fei Xie
2026-09-21  9:36 ` [RFC PATCH 1/4] dt-bindings: spi: cdns,xspi: add SPI NAND compatible Fei Xie
2026-09-21 14:01   ` Mark Brown
2026-09-23 12:54   ` Krzysztof Kozlowski
2026-09-21  9:36 ` [RFC PATCH 2/4] spi: cadence-xspi: add ACMD support for SPI NAND Fei Xie
2026-09-21 14:51   ` Mark Brown
2026-09-23  6:12     ` Fei Xie
2026-09-24 18:55       ` Mark Brown
2026-09-25  9:45         ` Miquel Raynal
2026-09-25 10:14           ` Nuno Sá
2026-09-25 10:23             ` Miquel Raynal
2026-09-25 11:31               ` Nuno Sá
2026-09-25 11:59               ` Mark Brown
2026-09-25 12:59                 ` Miquel Raynal [this message]
2026-09-25 16:38                   ` Mark Brown
2026-09-23 12:37     ` Nuno Sá
2026-09-21  9:37 ` [RFC PATCH 3/4] spi: cadence-xspi: factor out reusable ACMD helpers Fei Xie
2026-09-21  9:37 ` [RFC PATCH 4/4] spi: cadence-xspi: add ACMD support for SPI NOR Fei Xie
2026-09-23 12:24 ` [RFC PATCH 0/4] spi: cadence-xspi: add ACMD PIO support for NAND and NOR Nuno Sá

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87qzihjxlo.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fei.xie@horizon.auto \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=pthombar@cadence.com \
    --cc=richard@nod.at \
    --cc=robh@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®