* [PATCH] ALSA: hda/cmedia: Remove duplicate pin configuration parsing
@ 2026-04-01 8:26 wangdich9700
2026-04-01 9:02 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: wangdich9700 @ 2026-04-01 8:26 UTC (permalink / raw)
To: perex, tiwai, wangdich9700, rf
Cc: kees, linux-sound, linux-kernel, wangdicheng
From: wangdicheng <wangdicheng@kylinos.cn>
The cmedia_probe() function calls snd_hda_parse_pin_defcfg() and
snd_hda_gen_parse_auto_config() twice unnecessarily. Remove The
duplicate code.
Signed-off-by: wangdicheng <wangdicheng@kylinos.cn>
---
sound/hda/codecs/cmedia.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/sound/hda/codecs/cmedia.c b/sound/hda/codecs/cmedia.c
index e6e12c01339f..88dd80d987d4 100644
--- a/sound/hda/codecs/cmedia.c
+++ b/sound/hda/codecs/cmedia.c
@@ -39,13 +39,6 @@ static int cmedia_probe(struct hda_codec *codec, const struct hda_device_id *id)
spec->out_vol_mask = (1ULL << 0x10);
}
- err = snd_hda_parse_pin_defcfg(codec, cfg, NULL, 0);
- if (err < 0)
- goto error;
- err = snd_hda_gen_parse_auto_config(codec, cfg);
- if (err < 0)
- goto error;
-
err = snd_hda_parse_pin_defcfg(codec, cfg, NULL, 0);
if (err < 0)
goto error;
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: hda/cmedia: Remove duplicate pin configuration parsing
2026-04-01 8:26 [PATCH] ALSA: hda/cmedia: Remove duplicate pin configuration parsing wangdich9700
@ 2026-04-01 9:02 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2026-04-01 9:02 UTC (permalink / raw)
To: wangdich9700
Cc: perex, tiwai, rf, kees, linux-sound, linux-kernel, wangdicheng
On Wed, 01 Apr 2026 10:26:25 +0200,
wangdich9700@163.com wrote:
>
> From: wangdicheng <wangdicheng@kylinos.cn>
>
> The cmedia_probe() function calls snd_hda_parse_pin_defcfg() and
> snd_hda_gen_parse_auto_config() twice unnecessarily. Remove The
> duplicate code.
>
> Signed-off-by: wangdicheng <wangdicheng@kylinos.cn>
Oh, that was a silly mistake that was introduced at the big code
change.
Applied now with the Fixes tag.
thanks,
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-04-01 9:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-04-01 8:26 [PATCH] ALSA: hda/cmedia: Remove duplicate pin configuration parsing wangdich9700
2026-04-01 9:02 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®