* [PATCH] ALSA: au88x0: Modify the incorrect format specifier
@ 2024-12-06 2:05 liujing
2024-12-06 12:48 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: liujing @ 2024-12-06 2:05 UTC (permalink / raw)
To: perex, tiwai, ghanshyam1898; +Cc: linux-sound, linux-kernel, liujing
Make a minor change to eliminate a static checker warning. The type
of chip->irq is unsigned int, so the correct format specifier should be
%u instead of %i.
Signed-off-by: liujing <liujing@cmss.chinamobile.com>
diff --git a/sound/pci/au88x0/au88x0.c b/sound/pci/au88x0/au88x0.c
index 62b10b0e07b1..e3b1d7116110 100644
--- a/sound/pci/au88x0/au88x0.c
+++ b/sound/pci/au88x0/au88x0.c
@@ -223,7 +223,7 @@ __snd_vortex_probe(struct pci_dev *pci, const struct pci_device_id *pci_id)
// Card details needed in snd_vortex_midi
strcpy(card->driver, CARD_NAME_SHORT);
sprintf(card->shortname, "Aureal Vortex %s", CARD_NAME_SHORT);
- sprintf(card->longname, "%s at 0x%lx irq %i",
+ sprintf(card->longname, "%s at 0x%lx irq %u",
card->shortname, chip->io, chip->irq);
// (4) Alloc components.
--
2.27.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: au88x0: Modify the incorrect format specifier
2024-12-06 2:05 [PATCH] ALSA: au88x0: Modify the incorrect format specifier liujing
@ 2024-12-06 12:48 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2024-12-06 12:48 UTC (permalink / raw)
To: liujing; +Cc: perex, tiwai, ghanshyam1898, linux-sound, linux-kernel
On Fri, 06 Dec 2024 03:05:43 +0100,
liujing wrote:
>
> Make a minor change to eliminate a static checker warning. The type
> of chip->irq is unsigned int, so the correct format specifier should be
> %u instead of %i.
>
> Signed-off-by: liujing <liujing@cmss.chinamobile.com>
In this particular case, it's better to correct snd_vortex.irq to be
normal signed int. The validity check is with a negative value, as
it's initialized with -1.
thanks,
Takashi
>
> diff --git a/sound/pci/au88x0/au88x0.c b/sound/pci/au88x0/au88x0.c
> index 62b10b0e07b1..e3b1d7116110 100644
> --- a/sound/pci/au88x0/au88x0.c
> +++ b/sound/pci/au88x0/au88x0.c
> @@ -223,7 +223,7 @@ __snd_vortex_probe(struct pci_dev *pci, const struct pci_device_id *pci_id)
> // Card details needed in snd_vortex_midi
> strcpy(card->driver, CARD_NAME_SHORT);
> sprintf(card->shortname, "Aureal Vortex %s", CARD_NAME_SHORT);
> - sprintf(card->longname, "%s at 0x%lx irq %i",
> + sprintf(card->longname, "%s at 0x%lx irq %u",
> card->shortname, chip->io, chip->irq);
>
> // (4) Alloc components.
> --
> 2.27.0
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-12-06 12:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-12-06 2:05 [PATCH] ALSA: au88x0: Modify the incorrect format specifier liujing
2024-12-06 12:48 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®