From: Yoshinori Sato <ysato@users.sourceforge.jp>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Rich Felker <dalias@libc.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sh: add missing EXPORT_SYMBOL() for __delay
Date: Mon, 16 Dec 2019 20:28:01 +0900 [thread overview]
Message-ID: <87r214fr26.wl-ysato@users.sourceforge.jp> (raw)
In-Reply-To: <87wob2clos.wl-kuninori.morimoto.gx@renesas.com>
On Thu, 12 Dec 2019 11:38:43 +0900,
Kuninori Morimoto wrote:
>
>
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> __delay() is used from kernel module.
> We need EXPORT_SYMBOL(), otherwise we will get compile error.
>
> ERROR: "__delay" [drivers/net/phy/mdio-cavium.ko] undefined!
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> arch/sh/lib/delay.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/sh/lib/delay.c b/arch/sh/lib/delay.c
> index dad8e6a..540e670 100644
> --- a/arch/sh/lib/delay.c
> +++ b/arch/sh/lib/delay.c
> @@ -29,6 +29,7 @@ void __delay(unsigned long loops)
> : "0" (loops)
> : "t");
> }
> +EXPORT_SYMBOL(__delay);
>
> inline void __const_udelay(unsigned long xloops)
> {
> --
> 2.7.4
>
Applied sh-next.
Thanks.
--
Yosinori Sato
next prev parent reply other threads:[~2019-12-16 11:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 2:38 Kuninori Morimoto
2019-12-12 7:43 ` Geert Uytterhoeven
2019-12-12 23:57 ` Kuninori Morimoto
2019-12-16 11:28 ` Yoshinori Sato [this message]
2020-07-22 2:38 ` Guenter Roeck
2020-07-22 22:52 ` Rich Felker
2020-07-22 23:52 ` Guenter Roeck
2020-07-24 19:44 ` Rich Felker
2020-07-24 23:25 ` Andrew Morton
2020-08-03 10:01 ` Geert Uytterhoeven
-- strict thread matches above, loose matches on Subject: below --
2019-12-12 2:34 morimoto
2019-12-12 2:36 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r214fr26.wl-ysato@users.sourceforge.jp \
--to=ysato@users.sourceforge.jp \
--cc=akpm@linux-foundation.org \
--cc=dalias@libc.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome