From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mathias Krause <minipli@googlemail.com>,
James Bottomley <JBottomley@Odin.com>
Subject: Re: [PATCH] lib/string_helpers: clarify esc arg in string_escape_mem
Date: Thu, 30 Jul 2015 21:52:31 +0200 [thread overview]
Message-ID: <87r3npbeyo.fsf@rasmusvillemoes.dk> (raw)
In-Reply-To: <20150723231448.GA19989@www.outflux.net> (Kees Cook's message of "Thu, 23 Jul 2015 16:14:48 -0700")
On Fri, Jul 24 2015, Kees Cook <keescook@chromium.org> wrote:
> The esc argument is used to reduce which characters will be escaped.
> For example, using " " with ESCAPE_SPACE will not produce any escaped
> spaces.
>
Yeah, I've been confused by this more than once - the old description
and the parameter name suggest that the esc string contains additional
characters to escape, not the other way around.
Could we also rename the parameter 'only' or something like that? In any
case,
Acked-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
next prev parent reply other threads:[~2015-07-30 19:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 23:14 Kees Cook
2015-07-30 19:52 ` Rasmus Villemoes [this message]
2015-07-30 20:30 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r3npbeyo.fsf@rasmusvillemoes.dk \
--to=linux@rasmusvillemoes.dk \
--cc=JBottomley@Odin.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minipli@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®