* Fix memory leak in sierra_release()
@ 2012-10-23 20:03 Lennart Sorensen
2012-10-24 11:00 ` Bjørn Mork
0 siblings, 1 reply; 3+ messages in thread
From: Lennart Sorensen @ 2012-10-23 20:03 UTC (permalink / raw)
To: linux-kernel; +Cc: Bjørn Mork, Len Sorensen, linux
I found a memory leak in sierra_release() (well sierra_probe() I guess)
that looses 8 bytes each time the driver releases a device.
Here is the patch to fix it.
diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c
index 01d882c..76ef95b 100644
--- a/drivers/usb/serial/sierra.c
+++ b/drivers/usb/serial/sierra.c
@@ -959,6 +959,7 @@ static void sierra_release(struct usb_serial *serial)
continue;
kfree(portdata);
}
+ kfree(serial->private);
}
#ifdef CONFIG_PM
--
Len Sorensen
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Fix memory leak in sierra_release()
2012-10-23 20:03 Fix memory leak in sierra_release() Lennart Sorensen
@ 2012-10-24 11:00 ` Bjørn Mork
2012-10-24 14:15 ` Lennart Sorensen
0 siblings, 1 reply; 3+ messages in thread
From: Bjørn Mork @ 2012-10-24 11:00 UTC (permalink / raw)
To: Lennart Sorensen; +Cc: linux-kernel, linux
"Lennart Sorensen" <lsorense@csclub.uwaterloo.ca> writes:
> I found a memory leak in sierra_release() (well sierra_probe() I guess)
> that looses 8 bytes each time the driver releases a device.
>
> Here is the patch to fix it.
>
> diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c
> index 01d882c..76ef95b 100644
> --- a/drivers/usb/serial/sierra.c
> +++ b/drivers/usb/serial/sierra.c
> @@ -959,6 +959,7 @@ static void sierra_release(struct usb_serial *serial)
> continue;
> kfree(portdata);
> }
> + kfree(serial->private);
> }
>
> #ifdef CONFIG_PM
Looks sensible to me, but needs a signed-off-by and CC to linux-usb.
Bjørn
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Fix memory leak in sierra_release()
2012-10-24 11:00 ` Bjørn Mork
@ 2012-10-24 14:15 ` Lennart Sorensen
0 siblings, 0 replies; 3+ messages in thread
From: Lennart Sorensen @ 2012-10-24 14:15 UTC (permalink / raw)
To: Bjørn Mork; +Cc: linux-kernel, linux
On Wed, Oct 24, 2012 at 01:00:21PM +0200, Bjørn Mork wrote:
> "Lennart Sorensen" <lsorense@csclub.uwaterloo.ca> writes:
>
> > I found a memory leak in sierra_release() (well sierra_probe() I guess)
> > that looses 8 bytes each time the driver releases a device.
> >
> > Here is the patch to fix it.
> >
> > diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c
> > index 01d882c..76ef95b 100644
> > --- a/drivers/usb/serial/sierra.c
> > +++ b/drivers/usb/serial/sierra.c
> > @@ -959,6 +959,7 @@ static void sierra_release(struct usb_serial *serial)
> > continue;
> > kfree(portdata);
> > }
> > + kfree(serial->private);
> > }
> >
> > #ifdef CONFIG_PM
>
> Looks sensible to me, but needs a signed-off-by and CC to linux-usb.
Oh yeah. I shouldn't send patches at the end of the day.
I will try again.
--
Len Sorensen
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-24 14:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-23 20:03 Fix memory leak in sierra_release() Lennart Sorensen
2012-10-24 11:00 ` Bjørn Mork
2012-10-24 14:15 ` Lennart Sorensen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome