From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: x86@kernel.org
Cc: devel@linuxdriverproject.org, linux-kernel@vger.kernel.org,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH v2] x86/hyperv: Handle unknown NMIs on one CPU when unknown_nmi_panic
Date: Thu, 01 Dec 2016 17:10:49 +0100 [thread overview]
Message-ID: <87shq7d3zq.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <20161201144550.14966-1-vkuznets@redhat.com> (Vitaly Kuznetsov's message of "Thu, 1 Dec 2016 15:45:50 +0100")
Vitaly Kuznetsov <vkuznets@redhat.com> writes:
[snip]
> static void __init ms_hyperv_init_platform(void)
> {
> /*
> @@ -183,6 +204,9 @@ static void __init ms_hyperv_init_platform(void)
> pr_info("HyperV: LAPIC Timer Frequency: %#x\n",
> lapic_timer_frequency);
> }
> +
> + register_nmi_handler(NMI_LOCAL, hv_nmi_unknown, NMI_FLAG_FIRST,
> + "hv_nmi_unknown");
This should probably be NMI_UNKNOWN instead of NMI_LOCAL. While it works
regardless and we don't have other NMIs on Hyper-V VMs (or do we?) I
think it would be better to do v3.
Sorry for the inconvenience.
--
Vitaly
prev parent reply other threads:[~2016-12-01 16:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-01 14:45 Vitaly Kuznetsov
2016-12-01 16:10 ` Vitaly Kuznetsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shq7d3zq.fsf@vitty.brq.redhat.com \
--to=vkuznets@redhat.com \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome