mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2 0/4] ALSA: hda/realtek: Add codec quirk entries
@ 2026-11-18  1:55 Zhang Heng
  2026-11-18  1:55 ` [PATCH v2 1/4] ALSA: hda/realtek: Add quirk for THUNDEROBOT Gravity16G2Pro Zhang Heng
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Zhang Heng @ 2026-11-18  1:55 UTC (permalink / raw)
  To: tiwai; +Cc: perex, linux-sound, linux-kernel, Zhang Heng

This series fixes four laptops by adding the corresponding codec quirk
entries: a THUNDEROBOT Gravity16G2Pro that loses speaker output after
S3 resume, an HP Pavilion 15-cw1xxx with silent internal speakers, a
Lenovo Yoga Pro 7 14ASP9 whose bass speaker is not bound due to a PCI
SSID collision, and an HP Laptop 15-fd1xxx with non-working mute and
mic-mute LEDs.

v2: Drop patch 1/4 (cs35l41 UX582ZM). Stefan Binding pointed out that
10431A8F uses internal boost, and Slaton Christie already sent the
correct configuration for this SSID on 30 Oct. Add a quirk for the HP
Laptop 15-fd1xxx mute/mic-mute LEDs instead. The other three realtek
quirks are unchanged.

Zhang Heng (4):
  ALSA: hda/realtek: Add quirk for THUNDEROBOT Gravity16G2Pro
  ALSA: hda/realtek: Add quirk for HP Pavilion 15-cw1xxx
  ALSA: hda/realtek: Add quirk for Lenovo Yoga Pro 7
  ALSA: hda/realtek: Enable mute LEDs on HP Laptop 15-fd1xxx

 sound/hda/codecs/realtek/alc269.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2 1/4] ALSA: hda/realtek: Add quirk for THUNDEROBOT Gravity16G2Pro
  2026-11-18  1:55 [PATCH v2 0/4] ALSA: hda/realtek: Add codec quirk entries Zhang Heng
@ 2026-11-18  1:55 ` Zhang Heng
  2026-11-18  1:55 ` [PATCH v2 2/4] ALSA: hda/realtek: Add quirk for HP Pavilion 15-cw1xxx Zhang Heng
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Zhang Heng @ 2026-11-18  1:55 UTC (permalink / raw)
  To: tiwai; +Cc: perex, linux-sound, linux-kernel, Zhang Heng

After S3 resume the ALC256 on this model has COEF 0x10 bit 9 set
(0x0220 instead of 0x0020) and the internal speaker stays silent.
Reuse ALC256_FIXUP_XIAOMI_PRO15_RESUME, which clears that bit on
every init, including resume.

Closes: https://bugzilla.kernel.org/show_bug.cgi?id=222028
Signed-off-by: Zhang Heng <zhangheng@kylinos.cn>
---
 sound/hda/codecs/realtek/alc269.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index a756e0076021..6d7bc33bd0d5 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -8367,6 +8367,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1462, 0xb171, "Cubi N 8GL (MS-B171)", ALC283_FIXUP_HEADSET_MIC),
 	SND_PCI_QUIRK(0x152d, 0x1082, "Quanta NL3", ALC269_FIXUP_LIFEBOOK),
 	SND_PCI_QUIRK(0x152d, 0x1262, "Huawei NBLB-WAX9N", ALC2XX_FIXUP_HEADSET_MIC),
+	SND_PCI_QUIRK(0x152d, 0x1577, "THUNDEROBOT Gravity16G2Pro", ALC256_FIXUP_XIAOMI_PRO15_RESUME),
 	SND_PCI_QUIRK(0x1558, 0x0353, "Clevo V35[05]SN[CDE]Q", ALC256_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x1558, 0x1323, "Clevo N130ZU", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x1558, 0x1325, "Clevo N15[01][CW]U", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
-- 
2.25.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2 2/4] ALSA: hda/realtek: Add quirk for HP Pavilion 15-cw1xxx
  2026-11-18  1:55 [PATCH v2 0/4] ALSA: hda/realtek: Add codec quirk entries Zhang Heng
  2026-11-18  1:55 ` [PATCH v2 1/4] ALSA: hda/realtek: Add quirk for THUNDEROBOT Gravity16G2Pro Zhang Heng
@ 2026-11-18  1:55 ` Zhang Heng
  2026-11-18  1:55 ` [PATCH v2 3/4] ALSA: hda/realtek: Add quirk for Lenovo Yoga Pro 7 14ASP9 Zhang Heng
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Zhang Heng @ 2026-11-18  1:55 UTC (permalink / raw)
  To: tiwai; +Cc: perex, linux-sound, linux-kernel, Zhang Heng, jmoises

HP Pavilion 15-cw1034la (ALC295, SSID 103c:8615) has silent internal
speakers with the generic fixup.  Add ALC295_FIXUP_HP_CW1XXX to set
COEF 0x0d=0xa023 and chain to ALC295_FIXUP_HP_X360.

Reported-by: jmoises <moises_gc97@hotmail.com>
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=221534
Signed-off-by: Zhang Heng <zhangheng@kylinos.cn>
---
 sound/hda/codecs/realtek/alc269.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index 6d7bc33bd0d5..84b145fa4e4d 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -4334,6 +4334,7 @@ enum {
 	ALC298_FIXUP_HUAWEI_MBX_STEREO,
 	ALC295_FIXUP_HP_X360,
 	ALC295_FIXUP_HP_PAVILION_X360,
+	ALC295_FIXUP_HP_CW1XXX,
 	ALC221_FIXUP_HP_HEADSET_MIC,
 	ALC285_FIXUP_LENOVO_HEADPHONE_NOISE,
 	ALC295_FIXUP_HP_AUTO_MUTE,
@@ -5835,6 +5836,16 @@ static const struct hda_fixup alc269_fixups[] = {
 		.chained = true,
 		.chain_id = ALC295_FIXUP_HP_X360
 	},
+	[ALC295_FIXUP_HP_CW1XXX] = {
+		.type = HDA_FIXUP_VERBS,
+		.v.verbs = (const struct hda_verb[]) {
+			{ 0x20, AC_VERB_SET_COEF_INDEX, 0x0d },
+			{ 0x20, AC_VERB_SET_PROC_COEF, 0xa023 },
+			{}
+		},
+		.chained = true,
+		.chain_id = ALC295_FIXUP_HP_X360
+	},
 	[ALC221_FIXUP_HP_HEADSET_MIC] = {
 		.type = HDA_FIXUP_PINS,
 		.v.pins = (const struct hda_pintbl[]) {
@@ -7754,6 +7765,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x8603, "HP Omen 17-cb0xxx", ALC285_FIXUP_HP_MUTE_LED),
 	SND_PCI_QUIRK(0x103c, 0x860c, "HP ZBook 17 G6", ALC285_FIXUP_HP_GPIO_AMP_INIT),
 	SND_PCI_QUIRK(0x103c, 0x860f, "HP ZBook 15 G6", ALC285_FIXUP_HP_GPIO_AMP_INIT),
+	SND_PCI_QUIRK(0x103c, 0x8615, "HP Pavilion 15-cw1xxx", ALC295_FIXUP_HP_CW1XXX),
 	SND_PCI_QUIRK(0x103c, 0x861f, "HP Elite Dragonfly G1", ALC285_FIXUP_HP_GPIO_AMP_INIT),
 	SND_PCI_QUIRK(0x103c, 0x864f, "HP Laptop 15-dy0xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
 	SND_PCI_QUIRK(0x103c, 0x869d, "HP", ALC236_FIXUP_HP_MUTE_LED),
-- 
2.25.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2 3/4] ALSA: hda/realtek: Add quirk for Lenovo Yoga Pro 7 14ASP9
  2026-11-18  1:55 [PATCH v2 0/4] ALSA: hda/realtek: Add codec quirk entries Zhang Heng
  2026-11-18  1:55 ` [PATCH v2 1/4] ALSA: hda/realtek: Add quirk for THUNDEROBOT Gravity16G2Pro Zhang Heng
  2026-11-18  1:55 ` [PATCH v2 2/4] ALSA: hda/realtek: Add quirk for HP Pavilion 15-cw1xxx Zhang Heng
@ 2026-11-18  1:55 ` Zhang Heng
  2026-11-18  1:55 ` [PATCH v2 4/4] ALSA: hda/realtek: Enable mute LEDs on HP Laptop 15-fd1xxx Zhang Heng
  2026-11-18 12:55 ` [PATCH v2 0/4] ALSA: hda/realtek: Add codec quirk entries Takashi Iwai
  4 siblings, 0 replies; 6+ messages in thread
From: Zhang Heng @ 2026-11-18  1:55 UTC (permalink / raw)
  To: tiwai; +Cc: perex, linux-sound, linux-kernel, Zhang Heng, Brett

Lenovo Yoga Pro 7 14ASP9 (ALC287, codec SSID 17aa:3903) has a silent
bass speaker.  Its PCI SSID 17aa:38a7 is shared with Y780P AMD YG dual,
so it matches ALC287_FIXUP_TAS2781_I2C instead of the bass-speaker
fixup. Match on codec SSID to apply
ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN.

Reported-by: Brett <brettwstevens69@gmail.com>
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=222007
Signed-off-by: Zhang Heng <zhangheng@kylinos.cn>
---
 sound/hda/codecs/realtek/alc269.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index 84b145fa4e4d..e7a49801d05e 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -8611,6 +8611,8 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x17aa, 0x3886, "Y780 VECO DUAL", ALC287_FIXUP_TAS2781_I2C),
 	SND_PCI_QUIRK(0x17aa, 0x3891, "Lenovo Yoga Pro 7 14AHP9", ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN),
 	SND_PCI_QUIRK(0x17aa, 0x38a5, "Y580P AMD dual", ALC287_FIXUP_TAS2781_I2C),
+	/* Yoga Pro 7 14ASP9 shares PCI SSID 17aa:38a7 with Y780P; match on codec SSID */
+	HDA_CODEC_QUIRK(0x17aa, 0x3903, "Lenovo Yoga Pro 7 14ASP9", ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN),
 	SND_PCI_QUIRK(0x17aa, 0x38a7, "Y780P AMD YG dual", ALC287_FIXUP_TAS2781_I2C),
 	SND_PCI_QUIRK(0x17aa, 0x38a8, "Y780P AMD VECO dual", ALC287_FIXUP_TAS2781_I2C),
 	SND_PCI_QUIRK(0x17aa, 0x38a9, "Thinkbook 16P", ALC287_FIXUP_MG_RTKC_CSAMP_CS35L41_I2C_THINKPAD),
-- 
2.25.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2 4/4] ALSA: hda/realtek: Enable mute LEDs on HP Laptop 15-fd1xxx
  2026-11-18  1:55 [PATCH v2 0/4] ALSA: hda/realtek: Add codec quirk entries Zhang Heng
                   ` (2 preceding siblings ...)
  2026-11-18  1:55 ` [PATCH v2 3/4] ALSA: hda/realtek: Add quirk for Lenovo Yoga Pro 7 14ASP9 Zhang Heng
@ 2026-11-18  1:55 ` Zhang Heng
  2026-11-18 12:55 ` [PATCH v2 0/4] ALSA: hda/realtek: Add codec quirk entries Takashi Iwai
  4 siblings, 0 replies; 6+ messages in thread
From: Zhang Heng @ 2026-11-18  1:55 UTC (permalink / raw)
  To: tiwai; +Cc: perex, linux-sound, linux-kernel, Zhang Heng

The HP Laptop 15-fd1xxx (ALC236, subsystem 103c:8cac) has no working
mute or mic-mute LED. Both are driven by the existing
ALC236_FIXUP_HP_MUTE_LED_MICMUTE_GPIO quirk (COEF 0x07 bit 0 and GPIO0,
active low), as confirmed by hda-verb tests. Add the SSID entry.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=195827
Signed-off-by: Zhang Heng <zhangheng@kylinos.cn>
---
 sound/hda/codecs/realtek/alc269.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index e7a49801d05e..140458b6ab00 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -8033,6 +8033,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x8ca2, "HP ZBook Power", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8ca4, "HP ZBook Fury", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8ca7, "HP ZBook Fury", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
+	SND_PCI_QUIRK(0x103c, 0x8cac, "HP Laptop 15-fd1xxx", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_GPIO),
 	SND_PCI_QUIRK(0x103c, 0x8caf, "HP Elite mt645 G8 Mobile Thin Client", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
 	SND_PCI_QUIRK(0x103c, 0x8cbc, "HP Pavilion Laptop 16-ag0xxx", ALC245_FIXUP_HP_X360_MUTE_LEDS),
 	SND_PCI_QUIRK(0x103c, 0x8cbd, "HP Pavilion Aero Laptop 13-bg0xxx", ALC245_FIXUP_HP_X360_MUTE_LEDS),
-- 
2.25.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 0/4] ALSA: hda/realtek: Add codec quirk entries
  2026-11-18  1:55 [PATCH v2 0/4] ALSA: hda/realtek: Add codec quirk entries Zhang Heng
                   ` (3 preceding siblings ...)
  2026-11-18  1:55 ` [PATCH v2 4/4] ALSA: hda/realtek: Enable mute LEDs on HP Laptop 15-fd1xxx Zhang Heng
@ 2026-11-18 12:55 ` Takashi Iwai
  4 siblings, 0 replies; 6+ messages in thread
From: Takashi Iwai @ 2026-11-18 12:55 UTC (permalink / raw)
  To: Zhang Heng; +Cc: tiwai, perex, linux-sound, linux-kernel

On Wed, 18 Nov 2026 02:55:48 +0100,
Zhang Heng wrote:
> 
> This series fixes four laptops by adding the corresponding codec quirk
> entries: a THUNDEROBOT Gravity16G2Pro that loses speaker output after
> S3 resume, an HP Pavilion 15-cw1xxx with silent internal speakers, a
> Lenovo Yoga Pro 7 14ASP9 whose bass speaker is not bound due to a PCI
> SSID collision, and an HP Laptop 15-fd1xxx with non-working mute and
> mic-mute LEDs.
> 
> v2: Drop patch 1/4 (cs35l41 UX582ZM). Stefan Binding pointed out that
> 10431A8F uses internal boost, and Slaton Christie already sent the
> correct configuration for this SSID on 30 Oct. Add a quirk for the HP
> Laptop 15-fd1xxx mute/mic-mute LEDs instead. The other three realtek
> quirks are unchanged.
> 
> Zhang Heng (4):
>   ALSA: hda/realtek: Add quirk for THUNDEROBOT Gravity16G2Pro
>   ALSA: hda/realtek: Add quirk for HP Pavilion 15-cw1xxx
>   ALSA: hda/realtek: Add quirk for Lenovo Yoga Pro 7
>   ALSA: hda/realtek: Enable mute LEDs on HP Laptop 15-fd1xxx

Applied all four patches now.  Thanks.


Takashi

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-11-18 12:55 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-18  1:55 [PATCH v2 0/4] ALSA: hda/realtek: Add codec quirk entries Zhang Heng
2026-11-18  1:55 ` [PATCH v2 1/4] ALSA: hda/realtek: Add quirk for THUNDEROBOT Gravity16G2Pro Zhang Heng
2026-11-18  1:55 ` [PATCH v2 2/4] ALSA: hda/realtek: Add quirk for HP Pavilion 15-cw1xxx Zhang Heng
2026-11-18  1:55 ` [PATCH v2 3/4] ALSA: hda/realtek: Add quirk for Lenovo Yoga Pro 7 14ASP9 Zhang Heng
2026-11-18  1:55 ` [PATCH v2 4/4] ALSA: hda/realtek: Enable mute LEDs on HP Laptop 15-fd1xxx Zhang Heng
2026-11-18 12:55 ` [PATCH v2 0/4] ALSA: hda/realtek: Add codec quirk entries Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®