* [PATCH] ieee802154: hwsim: fix edge allocation leak and netlink attribute validation
@ 2026-09-19 22:34 Hui Peng
2026-09-20 13:01 ` Miquel Raynal
0 siblings, 1 reply; 2+ messages in thread
From: Hui Peng @ 2026-09-19 22:34 UTC (permalink / raw)
To: alex.aring, stefan, miquel.raynal, davem, edumazet, kuba, pabeni
Cc: linux-wpan, netdev, linux-kernel
In drivers/net/ieee802154/mac802154_hwsim.c, clean up allocated edges
and phys on error paths and validate netlink attribute bounds.
Fixes: f25da51fdc38 ("ieee802154: hwsim: add replacement for fakelb")
Assisted-by: LLM
Signed-off-by: Hui Peng <benquike@gmail.com>
---
diff --git a/drivers/net/ieee802154/mac802154_hwsim.c b/drivers/net/ieee802154/mac802154_hwsim.c
index a9bd1555d2dc..1b325d665177 100644
--- a/drivers/net/ieee802154/mac802154_hwsim.c
+++ b/drivers/net/ieee802154/mac802154_hwsim.c
@@ -987,6 +987,8 @@ static int hwsim_add_one(struct genl_info *info, struct device *dev,
err_subscribe:
ieee802154_unregister_hw(phy->hw);
+ kfree_rcu(rcu_dereference_protected(phy->pib, 1), rcu);
+ goto err_pib;
err_reg:
kfree(pib);
err_pib:
@@ -1003,6 +1005,8 @@ static void hwsim_del(struct hwsim_phy *phy)
list_del(&phy->list);
+ ieee802154_unregister_hw(phy->hw);
+
rcu_read_lock();
list_for_each_entry_rcu(e, &phy->edges, list) {
list_del_rcu(&e->list);
@@ -1013,7 +1017,6 @@ static void hwsim_del(struct hwsim_phy *phy)
kfree_rcu(pib, rcu);
- ieee802154_unregister_hw(phy->hw);
ieee802154_free_hw(phy->hw);
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ieee802154: hwsim: fix edge allocation leak and netlink attribute validation
2026-09-19 22:34 [PATCH] ieee802154: hwsim: fix edge allocation leak and netlink attribute validation Hui Peng
@ 2026-09-20 13:01 ` Miquel Raynal
0 siblings, 0 replies; 2+ messages in thread
From: Miquel Raynal @ 2026-09-20 13:01 UTC (permalink / raw)
To: Hui Peng
Cc: alex.aring, stefan, davem, edumazet, kuba, pabeni, linux-wpan,
netdev, linux-kernel
On 19/09/2026 at 22:34:34 GMT, Hui Peng <benquike@gmail.com> wrote:
> In drivers/net/ieee802154/mac802154_hwsim.c, clean up allocated edges
> and phys on error paths and validate netlink attribute bounds.
>
> Fixes: f25da51fdc38 ("ieee802154: hwsim: add replacement for fakelb")
> Assisted-by: LLM
> Signed-off-by: Hui Peng <benquike@gmail.com>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-20 13:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-19 22:34 [PATCH] ieee802154: hwsim: fix edge allocation leak and netlink attribute validation Hui Peng
2026-09-20 13:01 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®