From: Javier Martinez Canillas <javierm@redhat.com>
To: Bart Van Assche <bvanassche@acm.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: "Maxime Ripard" <mripard@kernel.org>,
linux-kernel@vger.kernel.org,
"Bart Van Assche" <bvanassche@acm.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Christian König" <christian.koenig@amd.com>,
"Dmitry Baryshkov" <dmitry.baryshkov@oss.qualcomm.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Nathan Chancellor" <nathan@kernel.org>
Subject: Re: [PATCH] drm/fb-helper: Fix a locking bug in an error path
Date: Thu, 09 Apr 2026 12:10:18 +0200 [thread overview]
Message-ID: <87v7e0igvp.fsf@ocarina.mail-host-address-is-not-set> (raw)
In-Reply-To: <20260403205355.1181984-1-bvanassche@acm.org>
Bart Van Assche <bvanassche@acm.org> writes:
> The name of the function __drm_fb_helper_initial_config_and_unlock() and
> also the comment above that function make it clear that all code paths
> in this function should unlock fb_helper->lock before returning. Add a
> mutex_unlock() call in the only code path where it is missing. This has
> been detected by the Clang thread-safety analyzer.
>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Christian König <christian.koenig@amd.com> # radeon
> Cc: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> # msm
> Cc: Javier Martinez Canillas <javierm@redhat.com>
> Fixes: 63c971af4036 ("drm/fb-helper: Allocate and release fb_info in single place")
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
Indeed, thanks for fixing this.
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
prev parent reply other threads:[~2026-04-09 10:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-03 20:53 Bart Van Assche
2026-04-07 7:44 ` Thomas Zimmermann
2026-04-07 7:47 ` Thomas Zimmermann
2026-04-07 15:17 ` Bart Van Assche
2026-04-07 15:27 ` Thomas Zimmermann
2026-04-09 10:10 ` Javier Martinez Canillas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v7e0igvp.fsf@ocarina.mail-host-address-is-not-set \
--to=javierm@redhat.com \
--cc=airlied@gmail.com \
--cc=bvanassche@acm.org \
--cc=christian.koenig@amd.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=nathan@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®