[PATCH] powerpc/makefile: remove check on obsolete GCC versions

[PATCH] powerpc/makefile: remove check on obsolete GCC versions

[Christophe Leroy]

Since commit cafa0010cd51 ("Raise the minimum required gcc version
to 4.6"), it is not possible to build kernel with GCC lower than 4.6

This patch removes checkbin tests addressing older versions of GCC.

Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
---
 arch/powerpc/Makefile | 28 ----------------------------
 1 file changed, 28 deletions(-)

diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile
index 8397c7bd5880..b33083bad840 100644
--- a/arch/powerpc/Makefile
+++ b/arch/powerpc/Makefile
@@ -405,35 +405,7 @@ archprepare: checkbin
 TOUT	:= .tmp_gas_check
 
 # Check gcc and binutils versions:
-# - gcc-3.4 and binutils-2.14 are a fatal combination
-# - Require gcc 4.0 or above on 64-bit
-# - gcc-4.2.0 has issues compiling modules on 64-bit
 checkbin:
-	@if test "$(cc-name)" != "clang" \
-	    && test "$(cc-version)" = "0304" ; then \
-		if ! /bin/echo mftb 5 | $(AS) -v -mppc -many -o $(TOUT) >/dev/null 2>&1 ; then \
-			echo -n '*** ${VERSION}.${PATCHLEVEL} kernels no longer build '; \
-			echo 'correctly with gcc-3.4 and your version of binutils.'; \
-			echo '*** Please upgrade your binutils or downgrade your gcc'; \
-			false; \
-		fi ; \
-	fi
-	@if test "$(cc-name)" != "clang" \
-	    && test "$(cc-version)" -lt "0400" \
-	    && test "x${CONFIG_PPC64}" = "xy" ; then \
-                echo -n "Sorry, GCC v4.0 or above is required to build " ; \
-                echo "the 64-bit powerpc kernel." ; \
-                false ; \
-        fi
-	@if test "$(cc-name)" != "clang" \
-	    && test "$(cc-fullversion)" = "040200" \
-	    && test "x${CONFIG_MODULES}${CONFIG_PPC64}" = "xyy" ; then \
-		echo -n '*** GCC-4.2.0 cannot compile the 64-bit powerpc ' ; \
-		echo 'kernel with modules enabled.' ; \
-		echo -n '*** Please use a different GCC version or ' ; \
-		echo 'disable kernel modules' ; \
-		false ; \
-	fi
 	@if test "x${CONFIG_CPU_LITTLE_ENDIAN}" = "xy" \
 	    && $(LD) --version | head -1 | grep ' 2\.24$$' >/dev/null ; then \
 		echo -n '*** binutils 2.24 miscompiles weak symbols ' ; \
-- 
2.13.3

Re: [PATCH] powerpc/makefile: remove check on obsolete GCC versions

[Joel Stanley]

Hey Christophe,

On Tue, 18 Sep 2018 at 15:13, Christophe Leroy <christophe.leroy@c-s.fr> wrote:
>
> Since commit cafa0010cd51 ("Raise the minimum required gcc version
> to 4.6"), it is not possible to build kernel with GCC lower than 4.6
>
> This patch removes checkbin tests addressing older versions of GCC.

This is the same as Nick's patch:

 https://patchwork.ozlabs.org/patch/969624/

Cheers,

Joel

Re: [PATCH] powerpc/makefile: remove check on obsolete GCC versions

[Christophe LEROY]

Le 18/09/2018 à 07:48, Joel Stanley a écrit :
> Hey Christophe,
> 
> On Tue, 18 Sep 2018 at 15:13, Christophe Leroy <christophe.leroy@c-s.fr> wrote:
>>
>> Since commit cafa0010cd51 ("Raise the minimum required gcc version
>> to 4.6"), it is not possible to build kernel with GCC lower than 4.6
>>
>> This patch removes checkbin tests addressing older versions of GCC.
> 
> This is the same as Nick's patch:
> 
>   https://patchwork.ozlabs.org/patch/969624/
> 

Oops, thanks, I missed that.

And even before Nick's, there is this one 
https://patchwork.ozlabs.org/patch/962319/

So I missed twice :(

Christophe

Re: [PATCH] powerpc/makefile: remove check on obsolete GCC versions

[Michael Ellerman]

Christophe LEROY <christophe.leroy@c-s.fr> writes:
> Le 18/09/2018 à 07:48, Joel Stanley a écrit :
>> Hey Christophe,
>> 
>> On Tue, 18 Sep 2018 at 15:13, Christophe Leroy <christophe.leroy@c-s.fr> wrote:
>>>
>>> Since commit cafa0010cd51 ("Raise the minimum required gcc version
>>> to 4.6"), it is not possible to build kernel with GCC lower than 4.6
>>>
>>> This patch removes checkbin tests addressing older versions of GCC.
>> 
>> This is the same as Nick's patch:
>> 
>>   https://patchwork.ozlabs.org/patch/969624/
>> 
>
> Oops, thanks, I missed that.
>
> And even before Nick's, there is this one 
> https://patchwork.ozlabs.org/patch/962319/
>
> So I missed twice :(

Haha, I missed that one too.

Everyone loves deleting code ;)

I have Nick's patch queued.

cheers