From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
x86@kernel.org, Andrew Jones <drjones@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [Xen-devel] [PATCH 1/5] x86/xen: start untangling PV and PVHVM guest support code
Date: Wed, 01 Mar 2017 10:38:49 +0100 [thread overview]
Message-ID: <87varttjyu.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <58638497-6660-6119-e24d-d2a8b05d99b0@suse.com> (Juergen Gross's message of "Wed, 1 Mar 2017 07:22:05 +0100")
Juergen Gross <jgross@suse.com> writes:
> On 24/02/17 17:14, Vitaly Kuznetsov wrote:
>> Introduce CONFIG_XEN_PV config option and split enlighten.c into
>> 4 files. Temporary add #ifdef CONFIG_XEN_PV to smp.c and mmu.c to
>> not break the build and not make the patch even bigger.
>>
>> xen_cpu_up_prepare*/xen_cpu_die hooks require separation to support
>> future xen_smp_intr_init() split.
>>
>> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
>
> Could you please split pure code movement and functional changes into
> different patches? This would make review much easier.
>
It's a bit hard with this series to make patches smaller and not break
the build ... :-(
> So 1 patch to split up enlightenment.c and at least one patch for the
> rest of the changes (Kconfig, splitting of x86_hyper_xen, ...).
This sounds doable, I'll try!
--
Vitaly
next prev parent reply other threads:[~2017-03-01 9:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-24 16:14 [PATCH 0/5] x86/xen: untangle " Vitaly Kuznetsov
2017-02-24 16:14 ` [PATCH 1/5] x86/xen: start untangling " Vitaly Kuznetsov
2017-03-01 6:22 ` [Xen-devel] " Juergen Gross
2017-03-01 9:38 ` Vitaly Kuznetsov [this message]
2017-02-24 16:14 ` [PATCH 2/5] x86/xen: split smp.c for PV and PVHVM guests Vitaly Kuznetsov
2017-03-01 6:24 ` [Xen-devel] " Juergen Gross
2017-02-24 16:14 ` [PATCH 3/5] x86/xen: put setup.c, mmu.c and p2m.c under CONFIG_XEN_PV Vitaly Kuznetsov
2017-03-01 6:25 ` [Xen-devel] " Juergen Gross
2017-02-24 16:14 ` [PATCH 4/5] x86/xen: put setup.c, pmu.c and apic.c " Vitaly Kuznetsov
2017-03-01 7:10 ` [Xen-devel] " Juergen Gross
2017-02-24 16:14 ` [PATCH 5/5] x86/xen: split suspend.c for PV and PVHVM guests Vitaly Kuznetsov
2017-03-01 7:14 ` [Xen-devel] " Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87varttjyu.fsf@vitty.brq.redhat.com \
--to=vkuznets@redhat.com \
--cc=boris.ostrovsky@oracle.com \
--cc=drjones@redhat.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome