mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] ASoC: tas571x: fix tas5733 num_controls
@ 2025-05-28  8:25 Bram Vlerick
  2025-05-28  8:42 ` Peter Korsgaard
  2025-05-28 13:20 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Bram Vlerick @ 2025-05-28  8:25 UTC (permalink / raw)
  To: Kevin Cernekee, Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai
  Cc: linux-sound, linux-kernel, peter, kamel.bouhara, Bram Vlerick

Commit e3de7984e451 ("ASoC: tas571x: add separate tas5733 controls")
introduces a separate struct for the tas5733 controls but did not update
the num_controls with the correct ARRAY_SIZE.

Fixes: e3de7984e451 ("ASoC: tas571x: add separate tas5733 controls")

Signed-off-by: Bram Vlerick <bram.vlerick@openpixelsystems.org>
---
 sound/soc/codecs/tas571x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/tas571x.c b/sound/soc/codecs/tas571x.c
index 00b131294547812f1406056d17e6c42ddf92003f..6bf37c77f0a77b11464a3560b1680fb89b0ed2dd 100644
--- a/sound/soc/codecs/tas571x.c
+++ b/sound/soc/codecs/tas571x.c
@@ -834,7 +834,7 @@ static const struct tas571x_chip tas5733_chip = {
 	.supply_names                   = tas5733_supply_names,
 	.num_supply_names               = ARRAY_SIZE(tas5733_supply_names),
 	.controls                       = tas5733_controls,
-	.num_controls                   = ARRAY_SIZE(tas5717_controls),
+	.num_controls                   = ARRAY_SIZE(tas5733_controls),
 	.regmap_config                  = &tas5733_regmap_config,
 	.vol_reg_size                   = 2,
 };

---
base-commit: 76f8d35964e4de1b464de22e4f3fdc14937ed854
change-id: 20250528-tas5733-fix-controls-size-4211444d4b31

Best regards,
-- 
Bram Vlerick <bram.vlerick@openpixelsystems.org>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: tas571x: fix tas5733 num_controls
  2025-05-28  8:25 [PATCH] ASoC: tas571x: fix tas5733 num_controls Bram Vlerick
@ 2025-05-28  8:42 ` Peter Korsgaard
  2025-05-28 13:20 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2025-05-28  8:42 UTC (permalink / raw)
  To: Bram Vlerick
  Cc: Kevin Cernekee, Liam Girdwood, Mark Brown, Jaroslav Kysela,
	Takashi Iwai, linux-sound, linux-kernel, kamel.bouhara

>>>>> "Bram" == Bram Vlerick <bram.vlerick@openpixelsystems.org> writes:

 > Commit e3de7984e451 ("ASoC: tas571x: add separate tas5733 controls")
 > introduces a separate struct for the tas5733 controls but did not update
 > the num_controls with the correct ARRAY_SIZE.

 > Fixes: e3de7984e451 ("ASoC: tas571x: add separate tas5733 controls")

 > Signed-off-by: Bram Vlerick <bram.vlerick@openpixelsystems.org>

Acked-by: Peter Korsgaard <peter@korsgaard.com>

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: tas571x: fix tas5733 num_controls
  2025-05-28  8:25 [PATCH] ASoC: tas571x: fix tas5733 num_controls Bram Vlerick
  2025-05-28  8:42 ` Peter Korsgaard
@ 2025-05-28 13:20 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2025-05-28 13:20 UTC (permalink / raw)
  To: Kevin Cernekee, Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
	Bram Vlerick
  Cc: linux-sound, linux-kernel, peter, kamel.bouhara

On Wed, 28 May 2025 10:25:48 +0200, Bram Vlerick wrote:
> Commit e3de7984e451 ("ASoC: tas571x: add separate tas5733 controls")
> introduces a separate struct for the tas5733 controls but did not update
> the num_controls with the correct ARRAY_SIZE.
> 
> Fixes: e3de7984e451 ("ASoC: tas571x: add separate tas5733 controls")
> 
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: tas571x: fix tas5733 num_controls
      commit: bc4005ef43104da589951dba69291360c6a11ae7

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-05-28 13:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-05-28  8:25 [PATCH] ASoC: tas571x: fix tas5733 num_controls Bram Vlerick
2025-05-28  8:42 ` Peter Korsgaard
2025-05-28 13:20 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®