[PATCH] patch_realtek: Splitting the UX3402 into two separate models.

[PATCH] patch_realtek: Splitting the UX3402 into two separate models.

[poseaydone]

From: Knyazev Arseniy <poseaydone@ya.ru>

UX3402VA and UX3402ZA models require different hex values, so comibining
them into one model is incorrect.

Signed-off-by: Knyazev Arseniy <poseaydone@ya.ru>
---
 sound/pci/hda/patch_realtek.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index b7e78bfcffd8..b002f947b0d2 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9812,7 +9812,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1043, 0x1d1f, "ASUS ROG Strix G17 2023 (G713PV)", ALC287_FIXUP_CS35L41_I2C_2),
 	SND_PCI_QUIRK(0x1043, 0x1d42, "ASUS Zephyrus G14 2022", ALC289_FIXUP_ASUS_GA401),
 	SND_PCI_QUIRK(0x1043, 0x1d4e, "ASUS TM420", ALC256_FIXUP_ASUS_HPE),
-	SND_PCI_QUIRK(0x1043, 0x1e02, "ASUS UX3402", ALC245_FIXUP_CS35L41_SPI_2),
+	SND_PCI_QUIRK(0x1043, 0x1e02, "ASUS UX3402ZA", ALC245_FIXUP_CS35L41_SPI_2),
+	SND_PCI_QUIRK(0x1043, 0x16a3, "ASUS UX3402VA", ALC245_FIXUP_CS35L41_SPI_2),
 	SND_PCI_QUIRK(0x1043, 0x1e11, "ASUS Zephyrus G15", ALC289_FIXUP_ASUS_GA502),
 	SND_PCI_QUIRK(0x1043, 0x1e12, "ASUS UM3402", ALC287_FIXUP_CS35L41_I2C_2),
 	SND_PCI_QUIRK(0x1043, 0x1e51, "ASUS Zephyrus M15", ALC294_FIXUP_ASUS_GU502_PINS),
-- 
2.42.0

Re: [PATCH] patch_realtek: Splitting the UX3402 into two separate models.

[Takashi Iwai]

On Wed, 13 Sep 2023 07:33:43 +0200,
poseaydone@ya.ru wrote:
> 
> From: Knyazev Arseniy <poseaydone@ya.ru>
> 
> UX3402VA and UX3402ZA models require different hex values, so comibining
> them into one model is incorrect.
> 
> Signed-off-by: Knyazev Arseniy <poseaydone@ya.ru>

Thanks, applied now.


Takashi

Re: [PATCH] patch_realtek: Splitting the UX3402 into two separate models.

[pizFunk]

How can I get my model number added to the patch_realtek file? It
suffers the same issue as the UX3402 and the line that needs to be
added for my model laptop is:

SND_PCI_QUIRK(0x1043, 0x1f62, "ASUS UX7602",
ALC245_FIXUP_CS35L41_SPI_2)

Since I see you're being more specific here in splitting the model
numbers, technically my full model number is: "UX7602ZM".

Again, when I patch this locally it works for my model number, but as
of yet only the other affected ASUS laptop modedls with my issue have
found their way into the kernel.

Thanks!

Re: [PATCH] patch_realtek: Splitting the UX3402 into two separate models.

[Matthew Pisoni]

Okay so how would I go about getting the following line added to the
patch_realtek file?

SND_PCI_QUIRK(0x1043, 0x1f62, "ASUS UX7602ZM",
ALC245_FIXUP_CS35L41_SPI_2)

It works on my machine I own that model I would just like it added as
other models have been so I don't need to continue to patch the kernel
module when it's already been effectively fixed for others.
This thread looked like you all were discussing modifications to that
file for this issue so I thought it might be a good place to start.

Thank you!