mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: NeilBrown <neilb@suse.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Ingo Molnar <mingo@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scripts: fix faddr2line to work on last symbol
Date: Fri, 13 Oct 2017 08:40:20 +1100	[thread overview]
Message-ID: <87wp40m4e3.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <20171012155555.jdryge43krhsjw64@treble>

[-- Attachment #1: Type: text/plain, Size: 724 bytes --]

On Thu, Oct 12 2017, Josh Poimboeuf wrote:

> On Thu, Oct 12, 2017 at 02:22:04PM +1100, NeilBrown wrote:
>> 
>> If faddr2line is given a function name which is the
>> last one listed by "nm -n", it will fail because it
>> never finds the next symbol.
>> 
>> So teach the awk script to catch that possibility,
>> and use 'size' to provide the end point of the last
>> function.
>> 
>> Signed-off-by: NeilBrown <neilb@suse.com>
>
> Thanks.  I'm assuming you saw this issue with a .o file, and not with
> vmlinux?  Because on my vmlinux, the last symbol isn't a text symbol.

Yes, I was using a .o

Thanks for looking further into this - there certainly are subtleties
that I missed.

Thanks,
NeilBrown

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

      parent reply	other threads:[~2017-10-12 21:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-12  3:22 NeilBrown
2017-10-12 15:55 ` Josh Poimboeuf
2017-10-12 19:27   ` Linus Torvalds
2017-10-12 21:40   ` NeilBrown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wp40m4e3.fsf@notabene.neil.brown.name \
    --to=neilb@suse.com \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome