* [PATCH ath-next] wifi: ath9k: use non devm for nvmem_cell_get
@ 2026-02-23 2:50 Rosen Penev
2026-02-23 15:21 ` Toke Høiland-Jørgensen
2026-04-30 21:30 ` Jeff Johnson
0 siblings, 2 replies; 3+ messages in thread
From: Rosen Penev @ 2026-02-23 2:50 UTC (permalink / raw)
To: linux-wireless; +Cc: Toke Høiland-Jørgensen, open list
There's absolutely no need to extend the lifetime of cell to post
removal of the driver. It's only used in this function.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/net/wireless/ath/ath9k/init.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c
index 28dc6c0e27aa..38fb1e763c6e 100644
--- a/drivers/net/wireless/ath/ath9k/init.c
+++ b/drivers/net/wireless/ath/ath9k/init.c
@@ -588,7 +588,7 @@ static int ath9k_nvmem_request_eeprom(struct ath_softc *sc)
size_t len;
int err;
- cell = devm_nvmem_cell_get(sc->dev, "calibration");
+ cell = nvmem_cell_get(sc->dev, "calibration");
if (IS_ERR(cell)) {
err = PTR_ERR(cell);
@@ -605,6 +605,7 @@ static int ath9k_nvmem_request_eeprom(struct ath_softc *sc)
}
buf = nvmem_cell_read(cell, &len);
+ nvmem_cell_put(cell);
if (IS_ERR(buf))
return PTR_ERR(buf);
--
2.53.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH ath-next] wifi: ath9k: use non devm for nvmem_cell_get
2026-02-23 2:50 [PATCH ath-next] wifi: ath9k: use non devm for nvmem_cell_get Rosen Penev
@ 2026-02-23 15:21 ` Toke Høiland-Jørgensen
2026-04-30 21:30 ` Jeff Johnson
1 sibling, 0 replies; 3+ messages in thread
From: Toke Høiland-Jørgensen @ 2026-02-23 15:21 UTC (permalink / raw)
To: Rosen Penev, linux-wireless; +Cc: open list
Rosen Penev <rosenp@gmail.com> writes:
> There's absolutely no need to extend the lifetime of cell to post
> removal of the driver. It's only used in this function.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
Right, makes sense.
Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH ath-next] wifi: ath9k: use non devm for nvmem_cell_get
2026-02-23 2:50 [PATCH ath-next] wifi: ath9k: use non devm for nvmem_cell_get Rosen Penev
2026-02-23 15:21 ` Toke Høiland-Jørgensen
@ 2026-04-30 21:30 ` Jeff Johnson
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Johnson @ 2026-04-30 21:30 UTC (permalink / raw)
To: linux-wireless, Rosen Penev
Cc: Toke Høiland-Jørgensen, linux-kernel
On Sun, 22 Feb 2026 18:50:20 -0800, Rosen Penev wrote:
> There's absolutely no need to extend the lifetime of cell to post
> removal of the driver. It's only used in this function.
>
>
Applied, thanks!
[1/1] wifi: ath9k: use non devm for nvmem_cell_get
commit: 22e8b91d18972f5e1de13af7f55555e550ad1818
Best regards,
--
Jeff Johnson <jeff.johnson@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-04-30 21:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-23 2:50 [PATCH ath-next] wifi: ath9k: use non devm for nvmem_cell_get Rosen Penev
2026-02-23 15:21 ` Toke Høiland-Jørgensen
2026-04-30 21:30 ` Jeff Johnson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®