From: Thomas Gleixner <tglx@linutronix.de>
To: Jules Irenge <jbi.octave@gmail.com>, julia.lawall@lip6.fr
Cc: boqun.feng@gmail.com, Jules Irenge <jbi.octave@example.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
"open list\:LOCKING PRIMITIVES" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 01/10] locking/rtmutex: Remove Comparison to bool
Date: Sat, 28 Mar 2020 12:28:30 +0100 [thread overview]
Message-ID: <87y2rkwwf5.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20200327212358.5752-2-jbi.octave@gmail.com>
Jules Irenge <jbi.octave@gmail.com> writes:
> From: Jules Irenge <jbi.octave@example.com>
>
> Coccinelle reports a warning inside rt_mutex_slowunlock()
>
> WARNING: Comparison to bool
>
> To fix this, the comparison to bool is removed
> This not only fixes the issue but also removes the unnecessary comparison.
>
> Remove comparison to bool
So you explain 3 times in different ways that the comparison to bool is
removed. What's the point?
Thanks,
tglx
next prev parent reply other threads:[~2020-03-28 11:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0/10>
[not found] ` <20200327212358.5752-1-jbi.octave@gmail.com>
2020-03-27 21:23 ` Jules Irenge
2020-03-28 11:28 ` Thomas Gleixner [this message]
2020-03-28 12:02 ` Jules Irenge
2020-03-28 12:44 ` Thomas Gleixner
2020-03-27 21:23 ` [PATCH 02/10] sched/topology: Replace 1 and 0 by boolean value Jules Irenge
2020-03-30 11:27 ` Peter Zijlstra
2020-04-03 16:23 ` Jules Irenge
2020-03-27 21:23 ` [PATCH 03/10] cpu: Remove Comparison to bool Jules Irenge
2020-03-28 11:29 ` Thomas Gleixner
2020-03-27 21:23 ` [PATCH 04/10] irq: Replace 1 by true Jules Irenge
2020-03-27 21:23 ` [PATCH 05/10] softirq: Replace BUG() after if statement with BUG_ON Jules Irenge
2020-03-28 11:22 ` Thomas Gleixner
2020-03-27 21:23 ` [PATCH 06/10] rcu: Replace assigned pointer ret value by corresponding boolean value Jules Irenge
2020-03-30 21:12 ` Paul E. McKenney
2020-03-27 21:23 ` [PATCH 07/10] sched/fair: Replace 1 and 0 by " Jules Irenge
2020-03-30 11:29 ` Peter Zijlstra
2020-03-27 21:23 ` [PATCH 08/10] trace: Replace printk and WARN_ON with WARN Jules Irenge
2020-03-27 21:23 ` [PATCH 09/10] kernel/sysctl.c: Replace 1 and 0 by corresponding boolean value Jules Irenge
2020-03-28 21:24 ` Kees Cook
2020-03-27 21:23 ` [PATCH 10/10] trace: Replace printk and WARN_ON with WARN Jules Irenge
2020-03-27 22:51 ` Steven Rostedt
2020-03-28 12:00 ` Jules Irenge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2rkwwf5.fsf@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=boqun.feng@gmail.com \
--cc=jbi.octave@example.com \
--cc=jbi.octave@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome