From: Jules Irenge <jbi.octave@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Jules Irenge <jbi.octave@gmail.com>,
julia.lawall@lip6.fr, boqun.feng@gmail.com,
Ingo Molnar <mingo@redhat.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 10/10] trace: Replace printk and WARN_ON with WARN
Date: Sat, 28 Mar 2020 12:00:32 +0000 (GMT) [thread overview]
Message-ID: <alpine.LNX.2.21.1.2003281159330.20453@ninjahost.lan> (raw)
In-Reply-To: <20200327185138.5e98e17b@gandalf.local.home>
On Fri, 27 Mar 2020, Steven Rostedt wrote:
> On Fri, 27 Mar 2020 21:23:57 +0000
> Jules Irenge <jbi.octave@gmail.com> wrote:
>
> > Coccinelle suggests replacing printk and WARN_ON with WARN
> >
> > SUGGESTION: printk + WARN_ON can be just WARN.
> > Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> > ---
> > kernel/trace/trace.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> > index 6b11e4e2150c..1fe31272ea73 100644
> > --- a/kernel/trace/trace.c
> > +++ b/kernel/trace/trace.c
> > @@ -1799,9 +1799,7 @@ static int run_tracer_selftest(struct tracer *type)
> > /* the test is responsible for resetting too */
> > tr->current_trace = saved_tracer;
> > if (ret) {
> > - printk(KERN_CONT "FAILED!\n");
> > - /* Add the warning after printing 'FAILED' */
>
> NACK! Did you not read the above comment. The FAILED goes with another
> print and should NOT be part of the WARN_ON.
>
> -- Steve
>
> > - WARN_ON(1);
> > + WARN(1, "FAILED!\n");
> > return -1;
> > }
> > /* Only reset on passing, to avoid touching corrupted buffers */
>
>
Thanks for the feedback, I will be more careful next time.
Kind regards,
Jules
prev parent reply other threads:[~2020-03-28 12:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0/10>
[not found] ` <20200327212358.5752-1-jbi.octave@gmail.com>
2020-03-27 21:23 ` [PATCH 01/10] locking/rtmutex: Remove Comparison to bool Jules Irenge
2020-03-28 11:28 ` Thomas Gleixner
2020-03-28 12:02 ` Jules Irenge
2020-03-28 12:44 ` Thomas Gleixner
2020-03-27 21:23 ` [PATCH 02/10] sched/topology: Replace 1 and 0 by boolean value Jules Irenge
2020-03-30 11:27 ` Peter Zijlstra
2020-04-03 16:23 ` Jules Irenge
2020-03-27 21:23 ` [PATCH 03/10] cpu: Remove Comparison to bool Jules Irenge
2020-03-28 11:29 ` Thomas Gleixner
2020-03-27 21:23 ` [PATCH 04/10] irq: Replace 1 by true Jules Irenge
2020-03-27 21:23 ` [PATCH 05/10] softirq: Replace BUG() after if statement with BUG_ON Jules Irenge
2020-03-28 11:22 ` Thomas Gleixner
2020-03-27 21:23 ` [PATCH 06/10] rcu: Replace assigned pointer ret value by corresponding boolean value Jules Irenge
2020-03-30 21:12 ` Paul E. McKenney
2020-03-27 21:23 ` [PATCH 07/10] sched/fair: Replace 1 and 0 by " Jules Irenge
2020-03-30 11:29 ` Peter Zijlstra
2020-03-27 21:23 ` [PATCH 08/10] trace: Replace printk and WARN_ON with WARN Jules Irenge
2020-03-27 21:23 ` [PATCH 09/10] kernel/sysctl.c: Replace 1 and 0 by corresponding boolean value Jules Irenge
2020-03-28 21:24 ` Kees Cook
2020-03-27 21:23 ` [PATCH 10/10] trace: Replace printk and WARN_ON with WARN Jules Irenge
2020-03-27 22:51 ` Steven Rostedt
2020-03-28 12:00 ` Jules Irenge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.21.1.2003281159330.20453@ninjahost.lan \
--to=jbi.octave@gmail.com \
--cc=boqun.feng@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®