From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Sergei Ianovich <ynvich@gmail.com>
Cc: linux-kernel@vger.kernel.org, Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
"moderated list\:PXA2xx\/PXA3xx SUPPORT"
<linux-arm-kernel@lists.infradead.org>,
"open list\:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Subject: Re: [PATCH v1] arm: pxa: fix DT node name for PXA27X usb
Date: Tue, 23 Feb 2016 21:12:25 +0100 [thread overview]
Message-ID: <87y4abuqxi.fsf@belgarion.home> (raw)
In-Reply-To: <1456228901.23036.9.camel@gmail.com> (Sergei Ianovich's message of "Tue, 23 Feb 2016 15:01:41 +0300")
Sergei Ianovich <ynvich@gmail.com> writes:
> Hi Robert,
>
> On Mon, 2016-02-22 at 16:35 +0100, Robert Jarzmik wrote:
>> You're right, I haven't seen the pxa2xx.dtsi statement before.
>>
>> As such, could you amend a bit your patch please to :
>> - add:
>> Fixes: 0ec1939668e5 ("ARM: dts: pxa: add the usb host controller")
>> - make the same change in pxa3xx.dtsi, as the same error is there
>> - and more globally align pxa2xx.dtsi, pxa27x.dtsi and pxa3xx.dtsi
>> - remove the compatible, reg, interrupts and status from both pxa27x.dtsi and
>> pxa3xx.dtsi as they are redundant with the included pxa2xxx.dsti one
>
> No problem. Let's figure out the best approach.
>
>> I'm even wondering if the proper change wouldn't be to scrap the ohci
>> declarations from pxa27x.dtsi and pxa3xx.dtsi, and only add the "clocks"
>> property to pxa2xx.dtsi ...
>
> Since clocks are declared in pxa27x.dtsi and pxa3xx.dtsi, there is a
> stronger ground to have node clocks properties set in pxa27x.dtsi
> and pxa3xx.dtsi as well. However, there is already nodes with clocks
> properties in pxa2xx.dtsi.
>
> I cannot choose, you should make a decision.
I have checked my manuals, and pxa25x doesn't have an USB Host controller.
So I'd rather have :
- remove the usb0: ohci@4c000000 node from pxa2xx.dtsi
- add it completely to pxa27x.dtsi and pxa3xx.dtsi, with clocks and everything,
in "disabled" status.
Cheers.
--
Robert
prev parent reply other threads:[~2016-02-23 20:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 11:08 Sergei Ianovich
2016-02-22 15:35 ` Robert Jarzmik
2016-02-23 12:01 ` Sergei Ianovich
2016-02-23 20:12 ` Robert Jarzmik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4abuqxi.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=daniel@zonque.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=haojian.zhuang@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=ynvich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®